Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
@mans2singh thanks for your recent updates, the property descriptor
improvements look good to me.
As far as property descriptors for data size ("10 KB") and duration ("1
minute") - I believe it is possible to let users specify "1 minute" or "5
minutes" while validating the range in milliseconds and retrieving the value in
milliseconds as a long integer. I also understand the value of transparently
passing values through to Kinesis library, and I don't feel strongly about this
either way. Let me know if some sample code would help.
Outstanding issues as I understand them:
* **AWS Processor Base Class** - I do not believe we need to change the
base class hierarchy for all AWS processors as part of this PR. I recommend
merging the code currently in AbstractBaseAWSProcessor into
AbstractKinesisProcessor, and reverting changes to AbstractAWSProcessor.
* **Notice/License text** - We will need to figure out what text is
required in the notice files for the KCL/KPL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
