Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69159093
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/SchemaLoader.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.minifi.commons.schema;
+
+import
org.apache.nifi.minifi.commons.schema.exception.SchemaLoaderException;
+import org.yaml.snakeyaml.Yaml;
+import org.yaml.snakeyaml.error.YAMLException;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Map;
+
+public class SchemaLoader {
+ public static Map<String, Object> loadYamlAsMap(InputStream
sourceStream) throws IOException, SchemaLoaderException {
+ try {
+ Yaml yaml = new Yaml();
+
+ // Parse the YAML file
+ final Object loadedObject = yaml.load(sourceStream);
+
+ // Verify the parsed object is a Map structure
+ if (loadedObject instanceof Map) {
+ return (Map<String, Object>) loadedObject;
+ } else {
+ throw new SchemaLoaderException("Provided YAML
configuration is not a Map");
+ }
+ } catch (YAMLException e ) {
+ throw new IOException(e);
+ } finally {
+ sourceStream.close();
+ }
+ }
+
+ public static ConfigSchema loadConfigSchema(InputStream sourceStream)
throws IOException, SchemaLoaderException {
--- End diff --
Since this is just a wrapper around loadYamlAsMap and has the requirement
that the input is Yaml, I'd prefer to have "Yaml" in somewhere in the method
name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
