On Thu, Mar 2, 2017 at 6:00 PM, Andre <[email protected]> wrote: > James, > > There's no doubt the Sign-off-by is redundant (as GIT itself holds that > information, reason why GH is still able to show the information without > the sign-of-by stamp), however, I agree with your view around positive > action and easy to refer as Bryan pointed. >
One important case where the signed-off-by isn't redundant (at least within git) is when there is more than one reviewer. This has been useful in some other projects, especially if folks get into the habit and there are multiple places reviews happen (e.g. both on JIRA and GitHub PRs). It's also been super helpful when non-committers are doing reviews. Another is when we get to the point of maintaining enough release lines that the person doing a backport commit might not be the person who did the initial review. The signed-off-by still carries useful information (albeit something we can kind-of get from JIRA) about who all did reviews.
