+1, binding Awesome stuff and a very welcomed enhancement to the NiFi ecosystem. Definitely a lot of neat potential to build on from here.
Comments: hashes and signatures good build and contrib-check looked good. Had some intermittent issues with NPM in a clean environment, repeating the build eventually got a complete and successful build. Subsequent builds beyond that point had no issues. minor: DEPENDENCIES file should be excluded from source packaging. not sure if this was a one-off from the release or could be prevented moving forward minor: build-and-run.sh/stop.sh might should make a check to see if the assembly exists Nothing of note in a scan of the L&N A quick start guide on integration in registry (and/or NiFi, didn't see it in the PR) would be great to capture. Had anticipated seeing this in the user/admin guide. Verified unsecured integration as highlighted in the helper. Actions seemed to make sense and work well after I got the flow mapped out mentally. On Thu, Dec 28, 2017 at 3:35 PM, Joe Witt <joe.w...@gmail.com> wrote: > +1 (binding) Release this package as nifi-registry-0.1.0 > > Release verification process > -pull source artifacts > -verify sigs > -verify commit id > -verify commit history reflects latest changes (based off commit > id/history) > -verify source README > -verify source L&N and that it is consistent with the work done in > https://issues.apache.org/jira/browse/NIFIREG-66 > -verify build w/contrib check > -verify binary/assembly README > -verify binary/assembly L&N and that it is consistent with work done in > https://issues.apache.org/jira/browse/NIFIREG-66 > -test registry on its own (manual/user testing) > -review registry docs > -setup certificate based secure reg setup/test > - build nifi with registry integration PR > - verify interaction with secure (certs based) nifi/secure registry > > Tests > - create empty group > - make local changes / view diffs / go to > - make sure nifi cannot do anything with the registry when its cert > lacks proxy auth > - once proxy auth added all options available > - verify can publish new versions/comments/ensure input is escaped > - change versions on a live flow with and without enqueued data > > Observations > - Having a default URL handler to show the 'you may have mistyped' > type page from nifi would be nice > - We should improve the logic of when components are started/stopped > to make version changes. For position changes only components should > not start/stop > - There are a lot of very cool features to add from here but this is a > pretty awesome first version with a range of excellent security > options/polish. > > > This is going to be a huge step forward for the community! > > Thanks > Joe > > On Thu, Dec 28, 2017 at 1:09 PM, Bryan Bende <bbe...@apache.org> wrote: > > Hello, > > > > I am pleased to be calling this vote for the source release of Apache > > NiFi Registry 0.1.0. > > > > The source zip, including signatures, digests, etc. can be found at: > > https://repository.apache.org/content/repositories/orgapachenifi-1115/ > > > > The Git tag is nifi-registry-0.1.0-RC1 > > The Git commit ID is 81b99e7b04491eabb72ddf30754053ca12d0fcca > > https://git-wip-us.apache.org/repos/asf?p=nifi-registry.git; > a=commit;h=81b99e7b04491eabb72ddf30754053ca12d0fcca > > > > Checksums of nifi-registry-0.1.0-source-release.zip: > > MD5: 56244c3c296cdc9c3fcc6d22590b80d1 > > SHA1: 6354e91f868f40d6656ec2467bde307260ad63ca > > SHA256: 2c680e441e6c4bfa2381bf004e9b19a6a79401a6a83e04597d0a714a95efd301 > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/bbende.asc > > > > KEYS file available here: > > https://dist.apache.org/repos/dist/release/nifi/KEYS > > > > 65 issues were closed/resolved for this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > ctId=12320920&version=12340217 > > > > Release note highlights can be found here: > > https://cwiki.apache.org/confluence/display/NIFI/Release+ > Notes#ReleaseNotes-NiFiRegistry0.1.0 > > > > The vote will be open for 96 hours. > > > > Please download the release candidate and evaluate the necessary items > > including checking hashes, signatures, build from source, and test. > > > > The please vote: > > > > [ ] +1 Release this package as nifi-registry-0.1.0 > > [ ] +0 no opinion > > [ ] -1 Do not release this package because... >
