+1 (binding) -verified signature and hashes -verified build on a slightly weird ubuntu 16.04 x86_64 (had a tough time with dependencies, but that was likely my environment). Got about 25% through a build on a clean Ubuntu MATE 16.04 on a raspberry pi 3, but that was looking good. -due to limited time, ran a couple very simple flows -reviewed LICENSE and NOTICE, saw no issues
On Sun, Jun 3, 2018 at 6:24 PM, Jeremy Dyer <[email protected]> wrote: > Tony - thanks for trying to verify the release! Always great to have > people helping out. Your right we do have enough votes for a pass though > but it's always great to have more feedback in case we missed something. > Sorry about the equipment failures and let me know if there is anything I > can o to help > > Thanks - Jeremy Dyer > ________________________________ > From: Tony Kurc <[email protected]> > Sent: Sunday, June 3, 2018 6:02:28 PM > To: [email protected] > Subject: Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.5.0 > > All, I haven't been able to verify this release due to some equipment > failure.. it looks like there is enough votes to pass, but I'm going to > keep trying. > > On Sun, Jun 3, 2018, 5:58 PM Joe Witt <[email protected]> wrote: > > > +1 (binding) > > > > Confirmed sigs, hashes, commit. > > Built on Fedora 28 > > Checked L&N. Wow that thing is serious! Nicely done. > > > > Ran flow example flow on fedora 28 build against latest nifi using > > example minificpp flow > > Ran flow example on osx convenience binary build against latest nifi > > use example minificpp flow > > > > Things look good. > > > > Oddity: > > - Under 'third-party' folder there is an empty 'apache-rat' directory > > > > Thanks > > Joe > > > > On Fri, Jun 1, 2018 at 3:43 PM, Aldrin Piri <[email protected]> > wrote: > > > +1, binding > > > > > > Comments: > > > * source matched the referenced commit > > > * L&N look good for the additions since 0.4.0 > > > * hashes and signature looked good > > > * build and tests checked out in CentOS, OS X 10.13, and Ubuntu 18.04 > > > driven by bootstrap > > > * verified functionality with some simple flows and Site to Site > transfer > > > to NiFi over an extended duration > > > > > > > > > As a note to other reviewers, the resulting assembly will be located in > > > your build directory as 'nifi-minifi-cpp-0.5.0-bin.tar.gz' > > > > > > Thanks for generating this RC, Jeremy and to all the contributors. A > lot > > > of great new bits in this release. > > > > > > --aldrin > > > > > > > > > On Fri, Jun 1, 2018 at 11:41 AM, Marc <[email protected]> wrote: > > > > > >> Jeremy, > > >> +1 binding > > >> > > >> Thanks for generating the release! > > >> > > >> I verified sigs and checksums. Built on u18 and OSX. > > >> > > >> I ran unit/integration tests with ctest. Also ran a simple flow with > > >> GetFile -> LogAttribute, but also includes two controller services for > > >> battery monitoring and network management. > > >> > > >> Thanks, > > >> Marc > > >> > > >> > > >> On Thu, May 31, 2018 at 8:39 PM, Jeremy Dyer <[email protected]> > > >> wrote: > > >> > Hello Apache NiFi Community, > > >> > > > >> > I am pleased to call this vote for the source release of Apache NiFi > > >> MiNiFi > > >> > C++, nifi-minifi-cpp-0.5.0. > > >> > > > >> > The source archive, signature, and digests can be located at: > > >> > > > >> > Source Archive: > > >> > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > >> > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz > > >> > > > >> > GPG armored signature: > > >> > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > >> > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.asc > > >> > > > >> > Source MD5: > > >> > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > >> > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.md5 > > >> > > > >> > Source SHA1: > > >> > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > >> > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.sha1 > > >> > > > >> > Source SHA256: > > >> > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > >> > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.sha256 > > >> > > > >> > The Git tag is minifi-cpp-0.5.0-RC1 > > >> > The Git commit hash is 5f3b3973e37def4d8ed2753837986d121fd58322 > > >> > * *https://git-wip-us.apache.org/repos/asf?p=nifi-minifi- > > >> cpp.git;a=commit;h=5f3b3973e37def4d8ed2753837986d121fd58322 > > >> > <https://git-wip-us.apache.org/repos/asf?p=nifi-minifi- > > >> cpp.git;a=commit;h=5f3b3973e37def4d8ed2753837986d121fd58322>* > > >> > * *https://github.com/apache/nifi-minifi-cpp/commit/ > > >> 5f3b3973e37def4d8ed2753837986d121fd58322 > > >> > <https://github.com/apache/nifi-minifi-cpp/commit/ > > >> 5f3b3973e37def4d8ed2753837986d121fd58322>* > > >> > > > >> > Checksums of nifi-minifi-cpp-0.5.0-source.tar.gz: > > >> > MD5: 9ec230b9ac3004981000276015860c52 > > >> > SHA1: a9e3fe34ed25f9f1a840cd318845bcdb6fb622f1 > > >> > SHA256: > > 78b5bbd65d1e3484efafc02a882f99063e06b88e1694daff6c24aaa3066037dc > > >> > > > >> > KEYS file available here: > > >> > https://dist.apache.org/repos/dist/dev/nifi/KEYS > > >> > > > >> > 87 issues were closed/resolved for this release: > > >> > *https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > >> projectId=12321520&version=12342659 > > >> > <https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > >> projectId=12321520&version=12342659>* > > >> > > > >> > Release note highlights can be found here: > > >> > *https://cwiki.apache.org/confluence/display/MINIFI/ > > >> Release+Notes#ReleaseNotes-Versioncpp-0.5.0 > > >> > <https://cwiki.apache.org/confluence/display/MINIFI/ > > >> Release+Notes#ReleaseNotes-Versioncpp-0.5.0>* > > >> > > > >> > The vote will close 3 June at 9PM EST. > > >> > > > >> > Please download the release candidate and evaluate the necessary > items > > >> > including checking hashes, signatures, build from source, and test. > > Then > > >> > please vote: > > >> > > > >> > [ ] +1 Release this package as nifi-minifi-cpp-0.4.0 > > >> > [ ] +0 no opinion > > >> > [ ] -1 Do not release this package because... > > >> > > > >> > Thanks! > > >> > > >
