Thanks for the feedback Koji. I removed the references to MD5 from the MiNiFi release wiki[1] so next time we will avoid supplying the MD5 checksum.
[1] - https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=70254849 On Mon, Jun 4, 2018 at 11:28 AM, Koji Kawamura <ijokaruma...@gmail.com> wrote: > +1 (binding) > > - Verified hashes > - Build and unit tests succeeded > - Run simple flows to send data from MiNiFi CPP to NiFi > - on Mac OS 10.13.4 > > I have a feedback on the release procedure. > Apache Release distribution policy has following: > "SHOULD NOT supply a MD5 checksum file (because MD5 is too broken)." > http://www.apache.org/dev/release-distribution#sigs-and-sums > NiFi release stopped supplying MD5 checksum since 1.6.0 and MiNiFi > should do that. > > Appreciate all the improvements and bug fixes for this release. Thanks > to Jeremy to take the release manager role! > > Thanks, > Koji > > On Mon, Jun 4, 2018 at 10:10 AM, Kevin Doran <kdo...@apache.org> wrote: > > +1 (non-binding) > > > > I followed the steps in the helper guide and was able to verify the > agent works as expected with a couple test flows that send data to NiFi > over s2s. Most of my RC verification was done with the agent on Mac OS > 10.12. A full build with tests passed on Ubuntu 16.04 for me. > > > > One very minor issue I ran into was a faulty Y/N prompt in bootstrap.sh > when selecting "N" to bail at the cmake confirmation. It doesn't really do > any harm as you can easily blow away the build dir and start over, and is > an easy fix. I filed a JIRA [1] and opened a PR that corrects it [2]. And > overall, the bootstrap stuff really makes this a lot easier to build and > deploy on new platforms, so I'm really enjoying using that. > > > > Great work everyone who contributed to the agent since the last release. > This is a nice step forward! And thanks Jeremy for managing the release! > > > > [1] https://issues.apache.org/jira/browse/MINIFICPP-523 > > [2] https://github.com/apache/nifi-minifi-cpp/pull/351 > > > > On 5/31/18, 20:39, "Jeremy Dyer" <jeremyd...@apache.org> wrote: > > > > Hello Apache NiFi Community, > > > > I am pleased to call this vote for the source release of Apache NiFi > MiNiFi > > C++, nifi-minifi-cpp-0.5.0. > > > > The source archive, signature, and digests can be located at: > > > > Source Archive: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz > > > > GPG armored signature: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.asc > > > > Source MD5: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.md5 > > > > Source SHA1: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.sha1 > > > > Source SHA256: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.sha256 > > > > The Git tag is minifi-cpp-0.5.0-RC1 > > The Git commit hash is 5f3b3973e37def4d8ed2753837986d121fd58322 > > * *https://git-wip-us.apache.org/repos/asf?p=nifi-minifi- > cpp.git;a=commit;h=5f3b3973e37def4d8ed2753837986d121fd58322 > > <https://git-wip-us.apache.org/repos/asf?p=nifi-minifi- > cpp.git;a=commit;h=5f3b3973e37def4d8ed2753837986d121fd58322>* > > * *https://github.com/apache/nifi-minifi-cpp/commit/ > 5f3b3973e37def4d8ed2753837986d121fd58322 > > <https://github.com/apache/nifi-minifi-cpp/commit/ > 5f3b3973e37def4d8ed2753837986d121fd58322>* > > > > Checksums of nifi-minifi-cpp-0.5.0-source.tar.gz: > > MD5: 9ec230b9ac3004981000276015860c52 > > SHA1: a9e3fe34ed25f9f1a840cd318845bcdb6fb622f1 > > SHA256: 78b5bbd65d1e3484efafc02a882f99063e06b88e1694daff6c24aaa30660 > 37dc > > > > KEYS file available here: > > https://dist.apache.org/repos/dist/dev/nifi/KEYS > > > > 87 issues were closed/resolved for this release: > > *https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12321520&version=12342659 > > <https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12321520&version=12342659>* > > > > Release note highlights can be found here: > > *https://cwiki.apache.org/confluence/display/MINIFI/ > Release+Notes#ReleaseNotes-Versioncpp-0.5.0 > > <https://cwiki.apache.org/confluence/display/MINIFI/ > Release+Notes#ReleaseNotes-Versioncpp-0.5.0>* > > > > The vote will close 3 June at 9PM EST. > > > > Please download the release candidate and evaluate the necessary > items > > including checking hashes, signatures, build from source, and test. > Then > > please vote: > > > > [ ] +1 Release this package as nifi-minifi-cpp-0.4.0 > > [ ] +0 no opinion > > [ ] -1 Do not release this package because... > > > > Thanks! > > > > > > >
