+1 binding - Verified signatures and hashes - Ran build using Maven Wrapper 3.9.6 - Ran build on macOS 14.2.1 with Azul Zulu JDK 1.8.0-392 AArch64 - Ran build on macOS 14.2.1 with Azul Zulu JDK 17.0.9 AArch64 - Ran build on Ubuntu 22.04 with Azul Zulu JDK 1.8.0-345 x86_64 - Ran build on Ubuntu 22.04 with Azul Zulu JDK 17.0.7 x86_64 - Ran NiFi system tests on macOS 14.2.1 with Azul Zulu JDK 1.8.0-392 AArch64 - Ran NiFi system tests on Ubuntu 22.04 with Azul Zulu JDK 1.8.0-345 x86_64
In the process of running the system tests, I found a failure for DefaultedDynamicClassPathModificationIT. This test is failing due to an upgrade from commons-lang3 3.13.0 to 3.14.0, and the fact that the test class is looking for a particular version. I created Jira issue NIFI-12680 [1] and submitted a pull request to resolve the problem, following the same approach already implemented on the main branch. Based on the fact that the system tests are not part of the standard review, and the fact that the failure relates to the test code itself, I do not see this as a blocking issue for releasing this version. Thanks Pierre! Regards, David Handermann On Thu, Jan 25, 2024 at 12:53 PM Pierre Villard <pierre.villard...@gmail.com> wrote: > > Team, > > I am pleased to be calling this vote for the source release of Apache NiFi > 1.25.0. > > Please review the following guide for how to verify a release candidate > build: > > https://cwiki.apache.org/confluence/display/NIFI/Release+Candidate+Verification > > The source being voted on the and the convenience binaries are available on > the Apache Distribution Repository: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-1.25.0 > > The build artifacts are available on the Apache Nexus Repository: > > https://repository.apache.org/content/repositories/orgapachenifi-1263 > > Git Tag: nifi-1.25.0-RC1 > Git Commit ID: 6ecc398d3f92425447e43242af4992757e25b3c5 > GitHub Commit Link: > https://github.com/apache/nifi/commit/6ecc398d3f92425447e43242af4992757e25b3c5 > > Checksums of nifi-1.25.0-source-release.zip > > SHA256: 6a14b35bf5beb4ae3fcf76df8d09676e61c6bc309a97dc6785eae84b7cbaef78 > SHA512: > 1ffb2586ce9591ce2c5aa39fdec43a89ffd29081a31d51dc95dd953cb7f94584d0a0171bb1ba7c9495f431aec3770d324dbabb319b01bb6fdce5a0a00426fffa > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/pvillard.asc > > KEYS file is available on the Apache Distribution Repository: > > https://dist.apache.org/repos/dist/release/nifi/KEYS > > Issues resolved for this version: 103 > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12353860 > > Release note highlights can be found on the project wiki: > > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.25.0 > > The vote will be open for 72 hours. > > Please download the release candidate and evaluate the necessary items > including checking hashes, signatures, build from source, and test. Then > please vote: > > [] +1 Release this package as nifi-1.25.0 > [] +0 no opinion > [] -1 Do not release this package because...