+1 binding Le mar. 30 janv. 2024 à 11:37, Zoltán Kornél Török <taz19880...@gmail.com> a écrit :
> +1 (non-binding) > - Built with macbook and with a debian machine > - Run some test flow against it, didn't find any issue > > Eric Secules <esecu...@gmail.com> ezt írta (időpont: 2024. jan. 29., H, > 22:00): > > > +1 (non-binding) > > > > > > - Verified signatures and hashes > > - Built on M2 Macbook air > > - Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > > Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec > > Java version: 11.0.21, vendor: Homebrew, runtime: > > /opt/homebrew/Cellar/openjdk@11 > > /11.0.21/libexec/openjdk.jdk/Contents/Home > > Default locale: en_CA, platform encoding: UTF-8 > > OS name: "mac os x", version: "14.2.1", arch: "aarch64", family: "mac" > > - My custom processors built on top of 1.25.0 > > > > > > > > On Mon, Jan 29, 2024 at 8:01 AM Dan S <dsti...@gmail.com> wrote: > > > > > +1 (non-binding) > > > > > > - Went through the Release Candidate Verification > > > < > > > > > > https://cwiki.apache.org/confluence/display/NIFI/Release+Candidate+Verification > > > > > > > - Verified signatures and hashes > > > - Built on CentOS Linux 7 > > > - Java version Red Hat, Inc. 1.8.0_392 > > > - Maven version 3.9.5 > > > - NIFI-12404, NIFI-12416, NIFI-12535 Confirmed the addition of > > > documentation regarding YamlTreeReader not supporting aliases, the > > > Additional Details section now visible for ExcelReader and > correction > > in > > > the expression language guide page. > > > - NIFI-12513 Confirmed the bug fix which now allows the URL > > mentioned > > > in the ticket to work. > > > - NIFI-12517 - Confirmed JSON with leading and trailing spaces are > > still > > > considered JSON with Expression Language isJson and the > > AttributesToJSON > > > processor. > > > - NIFI-12408 - Confirmed the addition of the pretty print option in > > the > > > AtttributesToJson processor and that it works, > > > - NIFI-11308 - Confirmed the added documentation highlighting the > > > availability of this system property and in practice seeing the > > current > > > version 1.25.0. > > > - NIFI-12410 - Confirmed that the starting row of an Excel > spreadsheet > > > can be specified with a flowfile attribute for ExcelReader. > > > - NIFI-12428 - Confirmed Enforcer rule for max Java version on 1.X > > > branch does not allow for Java 21 > > > - NIFI-12639 - Confirmed the ability to have a heterogenous schema > > cache > > > of Json schemas with different versions to validate incoming JSON > > > flowfiles. > > > - NIFI-12587 NIFI-12593 NIFI-10573 Confirmed improved error > validation > > > messages for ValidateCSV. > > > - NIFI-12561 Confirmed improvement for MonitorActivity to only emit > a > > > flowfile for inactivity when there actually had been activity as > > > opposed to > > > set amount of time even though there had not been activity. > > > - NIFI-12561 Confirmed fix for MergeContent processor not to use > text > > > delimiters when 'Do Not Use Delimiters' strategy is chosen. > > > > > > > > > Thanks for RMing, Pierre! > > > > > > On Sun, Jan 28, 2024 at 8:31 PM Mark Bean <mark.o.b...@gmail.com> > wrote: > > > > > > > +1 (non-binding) > > > > > > > > Verified signature and hashes > > > > Performed complete build with -Pcontrib-check > > > > Maven 3.9.3 > > > > Java 1.8.0_392 (OpenJDK) > > > > Ubuntu 22.04.3 > > > > > > > > Installed NiFi in different scenarios: > > > > - default configuration (single-user) > > > > - customized configuration (admin user) but no flow > > > > - upgrade from NiFi 1.24.0 > > > > > > > > Successfully imported a flow from NiFi Registry 1.24.0 > > > > > > > > Successfully upgraded NiFi Registry from 1.24.0 to 1.25.0. Successful > > > > import of flows into NiFi 1.25.0. > > > > > > > > Ran some basic flows and did not find any significant issues. > > > > > > > > On Sun, Jan 28, 2024 at 8:02 AM Csaba Bejan <bejan.cs...@gmail.com> > > > wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > Went through the helper guide and did a clean build > > > > > Verified signatures and hashes > > > > > Built on OSX 14.2.1 > > > > > Java version: 11.0.20, OpenJDK 64-Bit Server VM Zulu11.66+15-CA > > (build > > > > > 11.0.20+8-LTS, mixed mode) > > > > > Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) > > > > > Started NiFi and created a simple flow > > > > > Started MiNiFi and verified integration with C2 Server. Played > around > > > > with > > > > > the C2 protocol (Operations - Update, Transfer, Describe...) > > > > > Thanks for RMing, Pierre! > > > > > > > > > > Regards, > > > > > > > > > > Csaba > > > > > > > > > > > > > > > > On 28 Jan 2024, at 05:28, Ferenc Kis <briansolo1...@gmail.com> > > > wrote: > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Went through the helper guide, local maven repo cleaned up, full > > > clean > > > > > > build with contrib check, verified signatures and hashes > > > > > > > > > > > > Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) > > > > > > Maven home: /Users/fkis/.sdkman/candidates/maven/current > > > > > > Java version: 1.8.0_362, vendor: Azul Systems, Inc., runtime: > > > > > > > > > > > > > > > > > > > > > /Users/fkis/.sdkman/candidates/java/8.0.362-zulu/zulu-8.jdk/Contents/Home/jre > > > > > > Default locale: en_HU, platform encoding: UTF-8 > > > > > > OS name: "mac os x", version: "14.2.1", arch: "aarch64", family: > > > "mac" > > > > > > > > > > > > Validations performed: > > > > > > - Started NiFi, created a simple flow with ListenHTTP and Input > > Port. > > > > > > Validated ListenHTTP processor is able to receive data > > > > > > - Started MiNiFi Java: > > > > > > * created a simple GenerateFlowFile -> InvokeHttp flow and > > > > > > GenerateFlowFile -> RemoteProcessGroup flow and pushed to MiNiFi > > via > > > C2 > > > > > > protocol. Validated that connectivity between NiFi and MiNiFi > works > > > via > > > > > > both InvokeHTTP and S2S > > > > > > > > > > > > Thanks for RMing Pierre! > > > > > > > > > > > > Regards > > > > > > Ferenc > > > > > > > > > > > > On Sat, Jan 27, 2024 at 9:05 PM Krisztina Zsihovszki < > > > > zsikr...@gmail.com > > > > > > > > > > > > wrote: > > > > > > > > > > > >> +1 (non-binding) > > > > > >> > > > > > >> - Verified signatures and hashes > > > > > >> - Ran build using Maven 3.8.7 on macOS 13.5 with openjdk 11.0.18 > > > > > 2023-01-17 > > > > > >> and Zulu17.42+19-CA (build 17.0.7+7-LTS) > > > > > >> - Contrib check, unit tests passed > > > > > >> > > > > > >> Checked basic flows and verified the following tickets: > > > > > >> > > > > > >> [NIFI-12331] - Introduce a PublishSlack processor > > > > > >> [NIFI-12386] - Add a FilterAttribute processor > > > > > >> > > > > > >> > > > > > >> Thanks for RM'ing, Pierre! > > > > > >> Regards, > > > > > >> > > > > > >> Krisztina > > > > > >> > > > > > >> On Sat, Jan 27, 2024 at 4:43 PM Márk Báthori < > > > bathori.m...@gmail.com> > > > > > >> wrote: > > > > > >> > > > > > >>> +1 non-binding > > > > > >>> > > > > > >>> Went through the verification guide, verified hashes and > > > signatures, > > > > > ran > > > > > >> a > > > > > >>> full build on NiFi with contrib-check successfully. > > > > > >>> > > > > > >>> Environment: > > > > > >>> - MacOs 13.4 (22F66) > > > > > >>> - OpenJDK Runtime Environment Zulu11.62+17-CA (build > > > 11.0.18+10-LTS) > > > > > >>> - Apache Maven 3.8.6 > > > > > >>> > > > > > >>> Created and ran various simple flows. > > > > > >>> > > > > > >>> Tested the following tickets: > > > > > >>> NIFI-11992 - Add PutZendeskTicket Processor and > ZendeskRecordSink > > > > > >>> NIFI-12520 - ExtractHL7Attributes processor ignores repeatable > > > field > > > > > >> values > > > > > >>> > > > > > >>> Thanks for RMing Pierre! > > > > > >>> > > > > > >>> Regards, > > > > > >>> Mark > > > > > >>> > > > > > >>> David Handermann <exceptionfact...@apache.org> ezt írta > > (időpont: > > > > > 2024. > > > > > >>> jan. 27., Szo, 5:37): > > > > > >>> > > > > > >>>> +1 binding > > > > > >>>> > > > > > >>>> - Verified signatures and hashes > > > > > >>>> - Ran build using Maven Wrapper 3.9.6 > > > > > >>>> - Ran build on macOS 14.2.1 with Azul Zulu JDK 1.8.0-392 > AArch64 > > > > > >>>> - Ran build on macOS 14.2.1 with Azul Zulu JDK 17.0.9 AArch64 > > > > > >>>> - Ran build on Ubuntu 22.04 with Azul Zulu JDK 1.8.0-345 > x86_64 > > > > > >>>> - Ran build on Ubuntu 22.04 with Azul Zulu JDK 17.0.7 x86_64 > > > > > >>>> - Ran NiFi system tests on macOS 14.2.1 with Azul Zulu JDK > > > 1.8.0-392 > > > > > >>>> AArch64 > > > > > >>>> - Ran NiFi system tests on Ubuntu 22.04 with Azul Zulu JDK > > > 1.8.0-345 > > > > > >>> x86_64 > > > > > >>>> > > > > > >>>> In the process of running the system tests, I found a failure > > for > > > > > >>>> DefaultedDynamicClassPathModificationIT. This test is failing > > due > > > to > > > > > >>>> an upgrade from commons-lang3 3.13.0 to 3.14.0, and the fact > > that > > > > the > > > > > >>>> test class is looking for a particular version. > > > > > >>>> > > > > > >>>> I created Jira issue NIFI-12680 [1] and submitted a pull > request > > > to > > > > > >>>> resolve the problem, following the same approach already > > > implemented > > > > > >>>> on the main branch. > > > > > >>>> > > > > > >>>> Based on the fact that the system tests are not part of the > > > standard > > > > > >>>> review, and the fact that the failure relates to the test code > > > > itself, > > > > > >>>> I do not see this as a blocking issue for releasing this > > version. > > > > > >>>> > > > > > >>>> Thanks Pierre! > > > > > >>>> > > > > > >>>> Regards, > > > > > >>>> David Handermann > > > > > >>>> > > > > > >>>> On Thu, Jan 25, 2024 at 12:53 PM Pierre Villard > > > > > >>>> <pierre.villard...@gmail.com> wrote: > > > > > >>>>> > > > > > >>>>> Team, > > > > > >>>>> > > > > > >>>>> I am pleased to be calling this vote for the source release > of > > > > Apache > > > > > >>>> NiFi > > > > > >>>>> 1.25.0. > > > > > >>>>> > > > > > >>>>> Please review the following guide for how to verify a release > > > > > >> candidate > > > > > >>>>> build: > > > > > >>>>> > > > > > >>>>> > > > > > >>>> > > > > > >>> > > > > > >> > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/NIFI/Release+Candidate+Verification > > > > > >>>>> > > > > > >>>>> The source being voted on the and the convenience binaries > are > > > > > >>> available > > > > > >>>> on > > > > > >>>>> the Apache Distribution Repository: > > > > > >>>>> > > > > > >>>>> https://dist.apache.org/repos/dist/dev/nifi/nifi-1.25.0 > > > > > >>>>> > > > > > >>>>> The build artifacts are available on the Apache Nexus > > Repository: > > > > > >>>>> > > > > > >>>>> > > > > > >> > > > https://repository.apache.org/content/repositories/orgapachenifi-1263 > > > > > >>>>> > > > > > >>>>> Git Tag: nifi-1.25.0-RC1 > > > > > >>>>> Git Commit ID: 6ecc398d3f92425447e43242af4992757e25b3c5 > > > > > >>>>> GitHub Commit Link: > > > > > >>>>> > > > > > >>>> > > > > > >>> > > > > > >> > > > > > > > > > > > > > > > https://github.com/apache/nifi/commit/6ecc398d3f92425447e43242af4992757e25b3c5 > > > > > >>>>> > > > > > >>>>> Checksums of nifi-1.25.0-source-release.zip > > > > > >>>>> > > > > > >>>>> SHA256: > > > > > >>> > 6a14b35bf5beb4ae3fcf76df8d09676e61c6bc309a97dc6785eae84b7cbaef78 > > > > > >>>>> SHA512: > > > > > >>>>> > > > > > >>>> > > > > > >>> > > > > > >> > > > > > > > > > > > > > > > 1ffb2586ce9591ce2c5aa39fdec43a89ffd29081a31d51dc95dd953cb7f94584d0a0171bb1ba7c9495f431aec3770d324dbabb319b01bb6fdce5a0a00426fffa > > > > > >>>>> > > > > > >>>>> Release artifacts are signed with the following key: > > > > > >>>>> > > > > > >>>>> https://people.apache.org/keys/committer/pvillard.asc > > > > > >>>>> > > > > > >>>>> KEYS file is available on the Apache Distribution Repository: > > > > > >>>>> > > > > > >>>>> https://dist.apache.org/repos/dist/release/nifi/KEYS > > > > > >>>>> > > > > > >>>>> Issues resolved for this version: 103 > > > > > >>>>> > > > > > >>>>> > > > > > >>>> > > > > > >>> > > > > > >> > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12353860 > > > > > >>>>> > > > > > >>>>> Release note highlights can be found on the project wiki: > > > > > >>>>> > > > > > >>>>> > > > > > >>>> > > > > > >>> > > > > > >> > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.25.0 > > > > > >>>>> > > > > > >>>>> The vote will be open for 72 hours. > > > > > >>>>> > > > > > >>>>> Please download the release candidate and evaluate the > > necessary > > > > > >> items > > > > > >>>>> including checking hashes, signatures, build from source, and > > > test. > > > > > >>> Then > > > > > >>>>> please vote: > > > > > >>>>> > > > > > >>>>> [] +1 Release this package as nifi-1.25.0 > > > > > >>>>> [] +0 no opinion > > > > > >>>>> [] -1 Do not release this package because... > > > > > >>>> > > > > > >>> > > > > > >> > > > > > > > > > > > > > > > > > > > > > > -- > Üdvözlettel, > Török Zoltán Kornél > 06-30-509-0541 >
