I think the integration between the PR (esp comments) and the notification list was an optional component last time I heard about it. If we're going to take regular contributions directly from github, we should make sure that is turned on so that the activity hits some ASF mailing list (though preferably not dev@nifi).
On Wed, Dec 10, 2014 at 9:10 PM, Joe Witt <[email protected]> wrote: > Thanks - if you think we're safe to accept contribs both as patches and PRs > provided it is tied to a valid Jira ticket in NIFI- then that sounds good > to me. > > Thanks > Joe > > On Wed, Dec 10, 2014 at 10:08 PM, Benson Margulies <[email protected]> > wrote: > > > Lucene encourages people to make a JIRA to go with their PR. However, I > can > > find you a legal JIRA that makes it quite clear that for small > > contributions there is no problem here. > > > > > > On Wed, Dec 10, 2014 at 9:54 PM, Joe Witt <[email protected]> wrote: > > > > > Benson, > > > > > > I think we should support contributions from folks both as patches and > > via > > > pull requests. I am inclined to think we should ask infra to add the > > > integration hook which will close out the PR. > > > > > > That said, as Billie noted there seems to be some concern over whether > a > > PR > > > from Github provides sufficient legal clarity. Did Lucene get beyond > > that? > > > > > > Thanks > > > Joe > > > > > > On Wed, Dec 10, 2014 at 1:12 PM, Benson Margulies < > [email protected] > > > > > > wrote: > > > > > > > Other communities are using a workflow in which a JIRA linked to a PR > > is > > > > good enough (e.g. Lucene), and there's an integration where a commit > > > > comment with a PR # closes the PR. > > > > > > > > So if you want that stuff, we should ask infra@ about it. > > > > > > > > > > > > On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <[email protected]> > > > > wrote: > > > > > > > > > No, an ICLA is not necessary for contributions submitted through > ASF > > > > > infrastructure. See the definition of Contribution and the section > > on > > > > > Submission of Contributions in the Apache License v. 2.0 ( > > > > > http://www.apache.org/licenses/LICENSE-2.0). > > > > > > > > > > If we want to be able to accept GitHub pull requests, the process > is > > > not > > > > as > > > > > clear. The first couple of paragraphs under "Reviewing contributor > > > > > changes" on http://accumulo.apache.org/git.html are worth reading. > > > Also > > > > > we > > > > > would need to make sure pull requests trigger an email to the dev > > list > > > -- > > > > > not sure if that is set up by default, or if we have to request it. > > > > > > > > > > On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <[email protected]> > > wrote: > > > > > > > > > > > Mentors, > > > > > > > > > > > > For NIFI-154 we received a patch via Jira. I read that this is > > > > > inherently > > > > > > considered a submission that is useable but that was on the > webpage > > > of > > > > > > another apache project. Is this correct? Do we need to request > > > ICLAs > > > > > > before we can use these things? > > > > > > > > > > > > Just want to make sure the process of accepting patches is > > > understood. > > > > > > > > > > > > Thanks > > > > > > Joe > > > > > > > > > > > > > > > > > > > > > -- Sean
