-1
`mvn clean verify` under win still doesn't work .
Regards,
Sergey
26.05.2020 19:54, Furkan KAMACI пишет:
Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
- Apache rat checks are OK
I have 2 advices:
1) Please use separate folders for different release candidates.
2) You can consider to use "release candidates" for your releasing policy.
PS: I get these errors when I run rat checks:
[ERROR] VM #displayTree: error : too few arguments to macro. Wanted 2 got 0
[ERROR] VM #menuItem: error : too few arguments to macro. Wanted 1 got 0
Kind Regards,
Furkan KAMACI
On Tue, May 26, 2020 at 7:27 PM Sergey Makov <[email protected]> wrote:
+1
Checked on MacOS only:
- mvn clean package verify (JDK 8 and JDK 11)
- file signatures
Thanks,
Sergey
On Tue, May 26, 2020 at 7:21 PM Nikita Ivanov <[email protected]> wrote:
+1
All usual checks + all tests under "mvn verify" work for me. Can someone
verify again whether tests are broken or not? I also checked the v0.6.0
tag
on Git - works too.
--
Nikita Ivanov
On Tue, May 26, 2020 at 3:24 AM Sergey Kamov <[email protected]>
wrote:
-1
tests don't work
- under mac - JVM crashed
- under win - it hangs
ticker created (NLPCRAFT-62
<https://issues.apache.org/jira/browse/NLPCRAFT-62> for version 0.6.0
<
https://issues.apache.org/jira/issues/?jql=project+%3D+NLPCRAFT+AND+fixVersion+%3D+0.6.0
)
Regards,
Sergey
25.05.2020 23:12, Aaron Radzinski пишет:
NLPCraft-ers,
This is the vote for release of NLPCraft v0.6.0. This release
includes a
number of bug fixes, improvements and brand new real-life example of
accessing SQL database using natural language.
Quick links:
1. Release location:
https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/
2. GitHub v0.6.0 tag:
https://github.com/apache/incubator-nlpcraft/tree/v0.6.0
3. JIRA issues closed:
https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347775
4. KEYS file:
https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
<https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347774>
The vote is formal, see voting guidelines here:
https://www.apache.org/foundation/voting.html
+1 - to accept Apache NLPCraft 0.6.0
0 - don't care either way
-1 - DO NOT accept Apache NLPCraft 0.6.0 (explain why)
See notes on how to verify release here:
https://www.apache.org/info/verification.html
The vote will be held for 72 hours and will end on May 28, 2020 at
midnight
MSK.
Thank you!
--
Aaron Radzinski
