[
https://issues.apache.org/jira/browse/NUTCH-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126826#comment-13126826
]
Lewis John McGibbney commented on NUTCH-1135:
---------------------------------------------
First and foremost, I must say a personal big thank you, and I'm sure I speak
on behalf of the dev community as well. Having looked at you proposed code, I
think it is definitely beneficial to include the testSinglethreaded test. It
gives the testGoraStorage a fluid nature and provides nice consistency. The
comments are excellent, exactly the type of thing we require. I would comment
though that the indent style is somewhat off when drawing comparison with the
rest of the nuctchgora codebase, would it be possible for you to edit this
please and resubmit a patch? If you could get this sorted, then it would be
great if some other folks could have a look and pass comments. I was fairly new
to the nutchgora test suites and have also been learning as we go along. The
delightful sight of nutchgora finally passing all test and building nearly
brought a tear to my eye :0)
> Fix TestGoraStorage for Nutchgora
> ---------------------------------
>
> Key: NUTCH-1135
> URL: https://issues.apache.org/jira/browse/NUTCH-1135
> Project: Nutch
> Issue Type: Sub-task
> Components: storage
> Affects Versions: nutchgora
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Critical
> Fix For: nutchgora
>
> Attachments: NUTCH-1135-v1.patch
>
>
> This issue is part of a larger target which aims to fix broken JUnit tests
> for Nutchgora
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
