[
https://issues.apache.org/jira/browse/NUTCH-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129838#comment-13129838
]
Lewis John McGibbney commented on NUTCH-1135:
---------------------------------------------
Hi Andrzej do you have any comments (or anyone else for that matter) on Ferdy's
v4 patch? Having tested the patch I can confirm that runtime for this test is
by far the longest for any of nutchgora existing tests, this of course can be
attributed to his decision to retain and revise testMultiProcess. Some pretty
comprehensive test output can be seen below
{code}
lewis@lewis-01:~/ASF/nutchgora/runtime/local$ bin/nutch junit
org.apache.nutch.storage.TestGoraStorage
...[Server@1ef4b31]: [Thread[main,5,main]]: checkRunning(false) entered
[Server@1ef4b31]: [Thread[main,5,main]]: checkRunning(false) exited
[Server@1ef4b31]: [Thread[main,5,main]]: setDaemon(true)
[Server@1ef4b31]: [Thread[main,5,main]]: setSilent(true)
[Server@1ef4b31]: Initiating startup sequence...
[Server@1ef4b31]: Server socket opened successfully in 38 ms.
[Server@1ef4b31]: Database [index=0, id=0,
db=mem:org.apache.nutch.storage.testgorastorage,
alias=org.apache.nutch.storage.testgorastorage] opened sucessfully in 0 ms.
[Server@1ef4b31]: Startup sequence completed in 39 ms.
[Server@1ef4b31]: 2011-10-18 17:18:03.852 HSQLDB server 2.2.4 is online on port
9001
[Server@1ef4b31]: To close normally, connect and execute SHUTDOWN SQL
[Server@1ef4b31]: From command line, use [Ctrl]+[C] to abort abruptly
===Process stream for Thread[pool-2-thread-3,5,main]
Starting!
Done.
===End of process stream.
===Process stream for Thread[pool-2-thread-1,5,main]
Starting!
Done.
===End of process stream.
===Process stream for Thread[pool-2-thread-4,5,main]
Starting!
Done.
===End of process stream.
===Process stream for Thread[pool-2-thread-2,5,main]
Starting!
Done.
===End of process stream.
[Server@1ef4b31]: Initiating shutdown sequence...
[Server@1ef4b31]: Shutdown sequence completed in 0 ms.
[Server@1ef4b31]: 2011-10-18 17:20:10.394 SHUTDOWN : System.exit() was not
called
Time: 142.643
OK (3 tests)
{code}
I am pretty convinced that the test satisfies your points made regarding
map-reduce processes.
I think a nice test would be to query a db for test data to ensure this are
working nicely on the gora-side, however as was mentioned previously, I think
this falls outside the scope of nutchgora and more directly on Gora itself.
I cna only shadow Andrzej's comments, thanks Ferdy for your hard work here. I
think were making great progress with this and look forward to seeing this
issue resolved.
> Fix TestGoraStorage for Nutchgora
> ---------------------------------
>
> Key: NUTCH-1135
> URL: https://issues.apache.org/jira/browse/NUTCH-1135
> Project: Nutch
> Issue Type: Sub-task
> Components: storage
> Affects Versions: nutchgora
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Critical
> Fix For: nutchgora
>
> Attachments: NUTCH-1135-v1.patch, NUTCH-1135-v2.patch,
> NUTCH-1135-v3.patch, NUTCH-1135-v4.patch
>
>
> This issue is part of a larger target which aims to fix broken JUnit tests
> for Nutchgora
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
