[ 
https://issues.apache.org/jira/browse/NUTCH-865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated NUTCH-865:
---------------------------------------

    Attachment: NUTCH-865.patch

OK, since the rather useless commit, I've compiled a patch using the code 
formatter application bundled with Eclipse. For some reason a rather nasty 
number of files have been skipped, these are as follows

{code}
lewis@lewis-desktop:~$ eclipse -application 
org.eclipse.jdt.core.JavaCodeFormatter -config 
~/ASF/trunk/eclipse-codeformat.xml ~/ASF/trunk
Configuration Name: /home/lewis/ASF/trunk/eclipse-codeformat.xml
Starting format job ...
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/test/org/apache/nutch/util/TestURLUtil.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/TestInjector.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/CrawlDBTestUtil.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/TestGenerator.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/test/org/apache/nutch/fetcher/TestFetcher.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/scoring-link/src/java/org/apache/nutch/scoring/link/LinkAnalysisScoringFilter.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/urlmeta/src/java/org/apache/nutch/scoring/urlmeta/URLMetaScoringFilter.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/scoring-opic/src/java/org/apache/nutch/scoring/opic/OPICScoringFilter.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/index-static/src/java/org/apache/nutch/indexer/staticfield/StaticFieldIndexer.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/language-identifier/src/java/org/apache/nutch/analysis/lang/HTMLLanguageParser.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/tld/src/java/org/apache/nutch/scoring/tld/TLDScoringFilter.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/subcollection/src/java/org/apache/nutch/collection/CollectionManager.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/urlfilter-domain/src/java/org/apache/nutch/urlfilter/domain/DomainURLFilter.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/parse-tika/src/java/org/apache/nutch/parse/tika/TikaConfig.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/parse-tika/src/java/org/apache/nutch/parse/tika/DOMContentUtils.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/index-more/src/test/org/apache/nutch/indexer/more/TestMoreIndexingFilter.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/plugin/parse-html/src/java/org/apache/nutch/parse/html/DOMContentUtils.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/GenericWritableConfigurable.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/TrieStringMatcher.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainStatistics.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainSuffixes.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/TopLevelDomain.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainSuffix.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/ObjectCache.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/EncodingDetector.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/util/NodeWalker.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolException.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolNotFound.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolStatus.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/net/protocols/ProtocolException.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/net/URLFilterException.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/net/URLNormalizers.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/metadata/Metadata.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/metadata/SpellCheckedMetadata.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilter.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/NodeDumper.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkRank.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/WebGraph.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/Loops.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkDumper.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/ScoreUpdater.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilterException.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilters.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbReducer.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbFilter.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Crawl.java. Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Injector.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Generator.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDb.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/URLPartitioner.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbMerger.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbReader.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbReader.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/AdaptiveFetchSchedule.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/MapWritable.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Inlinks.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/DefaultFetchSchedule.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbFilter.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbMerger.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/TextProfileSignature.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/NutchWritable.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexingFiltersChecker.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrIndexer.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrMappingReader.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrClean.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrDeleteDuplicates.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrWriter.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchDocument.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexerOutputFormat.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchField.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexingException.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchIndexWriterFactory.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexerMapReduce.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/ExtensionPoint.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginDescriptor.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginRepository.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginManifestParser.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/Extension.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMerger.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMergeFilters.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/ContentAsTextInputFormat.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMergeFilter.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentReader.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/OldFetcher.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/FetcherOutputFormat.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseCallable.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParsePluginList.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseOutputFormat.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseResult.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParserFactory.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParsePluginsReader.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseException.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParserChecker.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseSegment.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/NotFoundHandler.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/SegmentHandler.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/LogDebugHandler.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/DelayHandler.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/FakeHandler.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/AbstractTestbedHandler.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcRecordReader.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcInputFormat.java. 
Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcSegmentCreator.java.
 Skip the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/FreeGenerator.java. Skip 
the file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/DmozParser.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/Benchmark.java. Skip the 
file.
The Eclipse formatter failed to format 
/home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/CrawlDBScanner.java. Skip 
the file.
Done.
{code}
                
> Format source code in unique style
> ----------------------------------
>
>                 Key: NUTCH-865
>                 URL: https://issues.apache.org/jira/browse/NUTCH-865
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Pham Tuan Minh
>            Assignee: Lewis John McGibbney
>             Fix For: 1.4
>
>         Attachments: NUTCH-865.patch
>
>
> We should define a standard format rules for source code/comments, then using 
> eclipse tool to format the whole source code in the same style. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to