Hi Lewis,
I attached patches for both trunk and nutchgora. As said for trunk
292 out of 304 files are re-formatted. The remaining 12 files look
perfect. For nutchgora 286 out of 302 files are affected.
I've looked into the changes: most are reasonable, sometimes comments
get worse by reformatting, e.g., ascii enumerations into one paragraph.
Sebastian
On 10/24/2011 10:15 AM, lewis john mcgibbney wrote:
Hi Sebastian,
Once again thanks for this. This is promising. Trunk is now 1.4 current
development [1]. The old trunk (Nutch 2.0) has now been shifted to nutchgora
branch [2]. At first looks nutchgora looks OK (ahem), and I suppose given
time this could be dealt with at a later stage, but if you are able to do
both projects then it would be a great help. We are hoping to get a trunk
1.4 RC rolling as soon as the code formatting is complete.
Thanks
Lewis
[1] https://svn.apache.org/repos/asf/nutch/trunk/
[2] https://svn.apache.org/repos/asf/nutch/branches/nutchgora/
On Mon, Oct 24, 2011 at 9:56 AM, Sebastian Nagel<[email protected]
wrote:
I tried with trunk. 292 files out of 304 java files have been changed.
I'll have a look into the remaining 12 files.
Maybe they are just already perfectly formatted.
I could create patches for branch-1.4 and trunk this evening. I guess
patches are required for both versions?
2011/10/24 lewis john mcgibbney<[email protected]>:
Hi Sebastian,
Are you working with most recent 1.4 dev?
If this is the case, would you be good enough to make the relevant change
to
changes.txt to merit your contribution, add the eclipse-configuration.xml
to
the svn area and attach a patch to the JIRA ticket. As I mentioned, I am
unable to do so just now, if you were able to do so it would be
absolutely
great.
Thanks for looking in to this. Can anyone confirm how many .java files
there
are in the /src directory? Juts so we know that we've got them all.
Thanks
Lewis
On Mon, Oct 24, 2011 at 12:05 AM, Sebastian Nagel
<[email protected]> wrote:
Hi,
I can only confirm that with Indigo the command line formatter fails on
source files using generics.
But when launched from the GUI it works. I imported the
eclipse-codeformat.xml (Properties> Java Code Style> Formatter) and
run it
on the project node (Source> Format). 292 files have been changed.
Sebastian
--
Lewis
