[ 
https://issues.apache.org/jira/browse/NUTCH-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406559#comment-13406559
 ] 

Markus Jelsma commented on NUTCH-1405:
--------------------------------------

This introduces some ambiguity. There are some possibilities such as ignore 
update of overwrite is false which would imply the following rules:

db.injector.overwrite=true && db.injector.update=false ==> overwrite
db.injector.overwrite=true && db.injector.update=true ==> update
db.injector.overwrite=false && db.injector.update=false ==> keep existing
db.injector.overwrite=false && db.injector.update=true ==> keep existing

or a problem:

db.injector.overwrite=true && db.injector.update=false ==> overwrite
db.injector.overwrite=true && db.injector.update=true ==> <WHAT TO DO>
db.injector.overwrite=false && db.injector.update=false ==> keep existing
db.injector.overwrite=false && db.injector.update=true ==> update

I'd propose update to be ignored is overwrite is false.
                
> Allow to overwrite CrawlDatum's with injected entries
> -----------------------------------------------------
>
>                 Key: NUTCH-1405
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1405
>             Project: Nutch
>          Issue Type: Improvement
>          Components: injector
>    Affects Versions: 1.5, 1.6
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>            Priority: Minor
>             Fix For: 1.6
>
>         Attachments: NUTCH-1405-1.6-3.patch, NUTCH-1405-1.6-4.patch, 
> NUTCH-1405-1.6-5.patch, NUTCH-1405-1.6-6.patch
>
>
> Injector's reducer does not permit overwriting existing CrawlDatum entries. 
> It is, however, useful to optionally overwrite so users can reset metadata 
> manually.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to