[ 
https://issues.apache.org/jira/browse/NUTCH-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747730#comment-13747730
 ] 

Markus Jelsma commented on NUTCH-1629:
--------------------------------------

No, not one file for both branches. Separate is easier. I think Julien meant 
the paths in the diff. See https://issues.apache.org/jira/browse/NUTCH-1501 for 
example. Patches `should` start at src/, not bla/bla/src or other.

It's not a big problem, passing -p1 will also patch your file correctly.
                
> there is no need to fail on empty lines in seed file when injecting.
> --------------------------------------------------------------------
>
>                 Key: NUTCH-1629
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1629
>             Project: Nutch
>          Issue Type: Improvement
>          Components: injector
>    Affects Versions: 2.2.1
>         Environment: Java 1.7.0_25
>            Reporter: kaveh minooie
>              Labels: easyfix
>             Fix For: 2.3
>
>         Attachments: 
> NUTCH-1629--no-need-to-fail-on-empty-lines-in-seed-files-1.x.patch, 
> NUTCH-1629--no-need-to-fail-on-empty-lines-in-seed-fi.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> right now, if there is an empty line in a seed file, TableUtil.reversUrl 
> would throw an exception that would kill the inject job. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to