[
https://issues.apache.org/jira/browse/NUTCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415687#comment-16415687
]
ASF GitHub Bot commented on NUTCH-1741:
---------------------------------------
lewismc commented on a change in pull request #304: NUTCH-1741 sitemaps
argument for generate, fetch, and parse, takes te…
URL: https://github.com/apache/nutch/pull/304#discussion_r177439896
##########
File path:
src/plugin/parse-sitemap/src/test/org/apache/nutch/parse/sitemap/TestNutchSitemapParser.java
##########
@@ -15,40 +15,30 @@
* limitations under the License.
*/
-package org.apache.nutch.parse;
+package org.apache.nutch.parse.sitemap;
+import org.apache.nutch.parse.ParseStatusUtils;
+import org.apache.nutch.parse.SitemapParse;
import org.apache.nutch.storage.ParseStatus;
import org.apache.nutch.storage.WebPage;
import org.apache.nutch.util.AbstractNutchTest;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
-import org.mockito.Mock;
import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import static org.junit.Assert.*;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-public class TestSitemapParser extends AbstractNutchTest {
-
- @Mock
+public class TestNutchSitemapParser {
+
WebPage page;
- @Override
@Before
public void setUp() throws Exception {
- super.setUp();
- page =mock(WebPage.class);
- }
-
- @Override
- @After
- public void tearDown() throws Exception {
- super.tearDown();
+ page = new WebPage();
Review comment:
I think this should use the full constructor
```
WebPage.newBuilder().build();;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support of Sitemaps in Nutch 2.x
> --------------------------------
>
> Key: NUTCH-1741
> URL: https://issues.apache.org/jira/browse/NUTCH-1741
> Project: Nutch
> Issue Type: New Feature
> Components: fetcher, generator
> Reporter: Alparslan Avcı
> Assignee: Cihad Guzel
> Priority: Major
> Labels: gsoc2015
> Fix For: 2.4
>
> Attachments: NUTCH-1741-v2.patch, NUTCH-1741-v3.patch,
> NUTCH-1741-v4.patch, NUTCH-1741-webpage-avsc.patch, NUTCH-1741.patch,
> NUTCH-1741v5.patch, NUTCH-1741v6.patch, NUTCH-1741v7.patch,
> SitemapCrawlerLifeCycle.pdf, SitemapDevelopmentFor2x.pdf
>
>
> Sitemap support has to be implemented for 2.x branch. It is being discussed
> in NUTCH-1465 for trunk.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
