[
https://issues.apache.org/jira/browse/NUTCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420539#comment-16420539
]
ASF GitHub Bot commented on NUTCH-1741:
---------------------------------------
benmvachon commented on a change in pull request #304: NUTCH-1741 sitemaps
argument for generate, fetch, and parse, takes te…
URL: https://github.com/apache/nutch/pull/304#discussion_r178298911
##########
File path:
src/plugin/parse-sitemap/src/java/org/apache/nutch/parse/sitemap/NutchSitemapParser.java
##########
@@ -62,7 +68,6 @@ public NutchSitemapParse getParse(String url, WebPage page) {
LOG.error(StringUtils.stringifyException(e));
}
Map<Outlink, Metadata> outlinkMap = null;
- Iterator i$;
if (siteMap.isIndex()) {
Review comment:
Here too:
https://github.com/benmvachon/nutch/blob/f314baf3d346f58c407977b65283fcf3e23055b5/src/java/org/apache/nutch/fetcher/FetcherReducer.java#L539
I don't see where this is actually adding the sitemap to the datastore for
generate jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support of Sitemaps in Nutch 2.x
> --------------------------------
>
> Key: NUTCH-1741
> URL: https://issues.apache.org/jira/browse/NUTCH-1741
> Project: Nutch
> Issue Type: New Feature
> Components: fetcher, generator
> Reporter: Alparslan Avcı
> Assignee: Cihad Guzel
> Priority: Major
> Labels: gsoc2015
> Fix For: 2.4
>
> Attachments: NUTCH-1741-v2.patch, NUTCH-1741-v3.patch,
> NUTCH-1741-v4.patch, NUTCH-1741-webpage-avsc.patch, NUTCH-1741.patch,
> NUTCH-1741v5.patch, NUTCH-1741v6.patch, NUTCH-1741v7.patch,
> SitemapCrawlerLifeCycle.pdf, SitemapDevelopmentFor2x.pdf
>
>
> Sitemap support has to be implemented for 2.x branch. It is being discussed
> in NUTCH-1465 for trunk.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
