[
https://issues.apache.org/jira/browse/NUTCH-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082615#comment-17082615
]
ASF GitHub Bot commented on NUTCH-2757:
---------------------------------------
sebastian-nagel commented on pull request #508: NUTCH-2757 : Indexer-elastic:
add authentication options
URL: https://github.com/apache/nutch/pull/508#discussion_r407676074
##########
File path:
src/plugin/indexer-elastic/src/java/org/apache/nutch/indexwriter/elastic/ElasticIndexWriter.java
##########
@@ -162,6 +191,17 @@ protected RestHighLevelClient
makeClient(IndexWriterParams parameters) throws IO
} else {
LOG.debug("No cluster name provided so using default");
}
+ //Only add username and password if password is configured
+ if(StringUtils.isNotBlank(password)) {
Review comment:
Great, @balashashanka! Looks good and should work.
Minor point: If possible try to apply the [Nutch Eclipse Code Formatting
rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml) and
also remove trailing white space. Are you using Eclipse? If not let me know or
whether you need help to set it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> indexer-elastic: add authentication options
> -------------------------------------------
>
> Key: NUTCH-2757
> URL: https://issues.apache.org/jira/browse/NUTCH-2757
> Project: Nutch
> Issue Type: Improvement
> Components: indexer, plugin
> Affects Versions: 1.16
> Reporter: Sebastian Nagel
> Assignee: Shashanka Balakuntala Srinivasa
> Priority: Major
> Fix For: 1.17
>
>
> The plugin
> [indexer-elastic-rest](https://github.com/apache/nutch/blob/ac9c435db2c9b1317fc195a762fa84d4e79fd97c/src/plugin/indexer-elastic-rest/README.md)
> allows to configure authentication properties (mainly user and password).
> This should be ported to the indexer-elastic plugin which is now REST-based
> (NUTCH-2739).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
