[
https://issues.apache.org/jira/browse/NUTCH-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083057#comment-17083057
]
ASF GitHub Bot commented on NUTCH-2757:
---------------------------------------
jorgelbg commented on pull request #508: NUTCH-2757 : Indexer-elastic: add
authentication options
URL: https://github.com/apache/nutch/pull/508#discussion_r408008904
##########
File path: conf/index-writers.xml.template
##########
@@ -108,8 +108,10 @@
<parameters>
<param name="host" value="localhost"/>
<param name="port" value="9200"/>
- <param name="cluster" value=""/>
Review comment:
Although the `cluster` property was removed here (and from the README) I
still see it used in the `ElasticConstants.java` and the
`ElasticIndexWriter.java` files. Do we want to get rid of this property? If so,
then I would advise removing all references from the plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> indexer-elastic: add authentication options
> -------------------------------------------
>
> Key: NUTCH-2757
> URL: https://issues.apache.org/jira/browse/NUTCH-2757
> Project: Nutch
> Issue Type: Improvement
> Components: indexer, plugin
> Affects Versions: 1.16
> Reporter: Sebastian Nagel
> Assignee: Shashanka Balakuntala Srinivasa
> Priority: Major
> Fix For: 1.17
>
>
> The plugin
> [indexer-elastic-rest](https://github.com/apache/nutch/blob/ac9c435db2c9b1317fc195a762fa84d4e79fd97c/src/plugin/indexer-elastic-rest/README.md)
> allows to configure authentication properties (mainly user and password).
> This should be ported to the indexer-elastic plugin which is now REST-based
> (NUTCH-2739).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
