[
https://issues.apache.org/jira/browse/NUTCH-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132972#comment-17132972
]
ASF GitHub Bot commented on NUTCH-2791:
---------------------------------------
pmezard commented on pull request #533:
URL: https://github.com/apache/nutch/pull/533#issuecomment-642450747
Fixed and rebased, PTAL.
Two questions:
- When you request changes, do you want them squashed immediately in the new
code or do you prefer independant commit. As a reviewer I prefer independant
commits to avoir having to re-read everything but the README suggests you
prefer to squash everything.
- What is the correct way to test such a change to nutch script help? I ran
`ant zip-bin` and redeployed the code locally but maybe there is something
faster, working directly in-tree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> domainstats, protocolstats and crawlcomplete do not handle GCS URLs
> -------------------------------------------------------------------
>
> Key: NUTCH-2791
> URL: https://issues.apache.org/jira/browse/NUTCH-2791
> Project: Nutch
> Issue Type: Bug
> Components: util
> Affects Versions: 1.16
> Reporter: Patrick Mézard
> Priority: Trivial
> Fix For: 1.17
>
>
> I am running Nutch in GCP Dataproc. The domainstats, protocolstats and
> crawlcomplete commands do not resolve crawldb paths correctly from GCS URLs.
> Also:
> * protocolstats has an off-by-one error when resolving the numReducers
> argument
> * crawlcomplete -inputDirs is inconsistent with other command: where
> domainstats expect directories containing a "current" path, crawlcomplete
> looks for directories containing a "crawldb/current" path.
> I will send a PR after creating the issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
