[
https://issues.apache.org/jira/browse/NUTCH-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133172#comment-17133172
]
ASF GitHub Bot commented on NUTCH-2791:
---------------------------------------
sebastian-nagel commented on pull request #533:
URL: https://github.com/apache/nutch/pull/533#issuecomment-642579892
> do you want them squashed immediately
> As a reviewer I prefer independant commits to avoir having to re-read
everything but the README suggests you prefer to squash everything.
I totally agree. It doesn't really matter if the changes are short (as
here). But if it's about hundred or more lines of code, separate commits (each
with a [meaningful commit
message](http://www.commitstrip.com/en/2017/09/12/versioning-is-important/))
are better. Same applies if a larger contribution includes automatic code
reformats or refactorings (usually no need to review them, at least, not
carefully).
> What is the correct way to test such a change to nutch script help? I ran
ant zip-bin and redeployed the code locally but maybe there is something
faster, working directly in-tree?
1. compile Nutch and build the runtime: `ant runtime` or just `ant`
2. then call `runtime/local/bin/nutch` (have a look at the environment
variables in `bin/nutch` which allow to override the log folder or directories
where config files are loaded from)
Testing of distributed mode is naturally much more complex (eg. see
[here](/sebastian-nagel/nutch-test-single-node-cluster))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> domainstats, protocolstats and crawlcomplete do not handle GCS URLs
> -------------------------------------------------------------------
>
> Key: NUTCH-2791
> URL: https://issues.apache.org/jira/browse/NUTCH-2791
> Project: Nutch
> Issue Type: Bug
> Components: util
> Affects Versions: 1.16
> Reporter: Patrick Mézard
> Priority: Trivial
> Fix For: 1.17
>
>
> I am running Nutch in GCP Dataproc. The domainstats, protocolstats and
> crawlcomplete commands do not resolve crawldb paths correctly from GCS URLs.
> Also:
> * protocolstats has an off-by-one error when resolving the numReducers
> argument
> * crawlcomplete -inputDirs is inconsistent with other command: where
> domainstats expect directories containing a "current" path, crawlcomplete
> looks for directories containing a "crawldb/current" path.
> I will send a PR after creating the issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
