[
https://issues.apache.org/jira/browse/NUTCH-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370497#comment-17370497
]
ASF GitHub Bot commented on NUTCH-2883:
---------------------------------------
sebastian-nagel commented on a change in pull request #691:
URL: https://github.com/apache/nutch/pull/691#discussion_r659610611
##########
File path: docker/Dockerfile
##########
@@ -20,10 +20,12 @@ WORKDIR /root/
# Install dependencies
RUN apk update
-RUN apk --no-cache add apache-ant bash git openjdk11
+RUN apk --no-cache add apache-ant bash git openjdk11 supervisor
+# Establish environment variables
RUN echo 'export JAVA_HOME=/usr/lib/jvm/java-11-openjdk' >> $HOME/.bashrc
-env NUTCH_HOME='/root/nutch_source/runtime/local'
+ENV JAVA_HOME '/usr/lib/jvm/java-11-openjdk'
Review comment:
The [Dockerfile
reference](https://docs.docker.com/engine/reference/builder/#env) discourages
the use of `ENV var val` in favor of `ENV var=val`. I've seen this variant the
first time and had to try out and read the documentation.
+1 to unify how JAVA_HOME and NUTCH_HOME are set. Also good not to force the
usage of the bash as command-line shell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide means to run server and webapp as persistent services in Docker
> container
> ---------------------------------------------------------------------------------
>
> Key: NUTCH-2883
> URL: https://issues.apache.org/jira/browse/NUTCH-2883
> Project: Nutch
> Issue Type: Improvement
> Components: docker, nutch server, web gui
> Affects Versions: 1.18
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.19
>
>
> Some conditional logic and some Docker build arguments would allow a user to
> run the nutch server alone or both the nutch server and webapp as long
> running services.
> This could be useful for users who want to remotely interact with Nutch via
> REST where jobs may actually be executed on yet another remote deployment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
