[ 
https://issues.apache.org/jira/browse/NUTCH-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376680#comment-17376680
 ] 

ASF GitHub Bot commented on NUTCH-2883:
---------------------------------------

sebastian-nagel commented on a change in pull request #691:
URL: https://github.com/apache/nutch/pull/691#discussion_r665509195



##########
File path: docker/config/supervisord_startserver.conf
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+[supervisord]
+childlogdir=/var/log/supervisord/
+logfile=/tmp/supervisord.log ; (main log file;default $CWD/supervisord.log)
+logfile_maxbytes=50MB       ; (max main logfile bytes b4 rotation;default 50MB)
+logfile_backups=10          ; (num of main logfile rotation backups;default 10)
+loglevel=info               ; (log level;default info; others: 
debug,warn,trace)
+minfds=1024                 ; (min. avail startup file descriptors;default 
1024)
+minprocs=200                ; (min. avail process descriptors;default 200)
+nodaemon=false              ; (start in foreground if true;default false)
+pidfile=/tmp/supervisord.pid ; (supervisord pidfile;default supervisord.pid)

Review comment:
       ... and pid files I'd expect in `/run/` or `/var/run/`

##########
File path: docker/config/supervisord_startserver.conf
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+[supervisord]
+childlogdir=/var/log/supervisord/
+logfile=/tmp/supervisord.log ; (main log file;default $CWD/supervisord.log)

Review comment:
       Not a common place for log files. Is there a reason why the log file 
isn't also placed in `/var/log/supervisord/`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide means to run server and webapp as persistent services in Docker 
> container
> ---------------------------------------------------------------------------------
>
>                 Key: NUTCH-2883
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2883
>             Project: Nutch
>          Issue Type: Improvement
>          Components: docker, nutch server, web gui
>    Affects Versions: 1.18
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Major
>             Fix For: 1.19
>
>
> Some conditional logic and some Docker build arguments would allow a user to 
> run the nutch server alone or both the nutch server and webapp as long 
> running services.
> This could be useful for users who want to remotely interact with Nutch via 
> REST where jobs may actually be executed on yet another remote deployment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to