lewismc commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1006021514
Hi @prakharchaube sterling job! Please consider the following ``` //parameterized logging... see https://www.slf4j.org/faq.html#logging_performance LOG.error("CrawlDb update job did not succeed, job id: {}, job status: {}, reason: {}", job.getJobID(), job.getStatus().getState(), job.getStatus().getFailureInfo()); ``` Vs what we currently have ``` String message = "CrawlDb update job did not succeed, job id: " + job.getJobID() + ", job status:" + job.getStatus().getState() + ", reason: " + job.getStatus().getFailureInfo(); LOG.error(message); ``` It's up to you if you want to implement this as a separate patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
