sebastian-nagel commented on pull request #721:
URL: https://github.com/apache/nutch/pull/721#issuecomment-1008803382


   Thanks, @prakharchaube - good idea! The code to handle job failures is kind 
of boilerplate for all Nutch tools. But there's some variation regarding the 
cleanup. In addition, log messages and stack traces should show the originating 
class (Injector, etc.) and not that of a utility class.
   
   > What about 
[StringUtil.java](https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/util/StringUtil.java)
   
   Maybe 
[NutchJob](https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/util/NutchJob.java)
 is also a good location for code for shared by Nutch tools/jobs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to