[
https://issues.apache.org/jira/browse/NUTCH-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469600#comment-17469600
]
ASF GitHub Bot commented on NUTCH-2923:
---------------------------------------
lewismc commented on pull request #721:
URL: https://github.com/apache/nutch/pull/721#issuecomment-1006175869
@prakharchaube
> I see the same String message is further used as...
That was bad of me. i should have looked another few lines down!
> What I can do is use String.format(); to initialize the value of the
message that would be neater.
I agree that it would make for cleaner code.
> is it the ideal exception choice here?
Let's leave this for another ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Job Id in Job Failure messages
> ----------------------------------
>
> Key: NUTCH-2923
> URL: https://issues.apache.org/jira/browse/NUTCH-2923
> Project: Nutch
> Issue Type: Improvement
> Components: crawldb, fetcher, generator, injector
> Reporter: Prakhar Chaube
> Priority: Minor
>
> In Job classes in case job doesn't succeed a failure message is initialized
> as follows:
> _String message = "Generator job did not succeed, job status:"_
> _+ job.getStatus().getState() + ", reason: "_
> _+ job.getStatus().getFailureInfo();_
> However, this message doesn't contain JobId which can make it really hard to
> reach the exact job from the logs. Adding JodId to this message will make it
> easier to track and locate for debugging.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
