[ 
https://issues.apache.org/jira/browse/NUTCH-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472163#comment-17472163
 ] 

ASF GitHub Bot commented on NUTCH-2923:
---------------------------------------

prakharchaube commented on pull request #721:
URL: https://github.com/apache/nutch/pull/721#issuecomment-1009130088


   @sebastian-nagel thanks for the suggestion, not to worry the stack trace 
would still show the logs origin as the Job Classes.
   
   > Maybe 
[NutchJob](https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/util/NutchJob.java)
 is also a good location for code for shared by Nutch tools/jobs.
   
   Instead of NutchJob I was thinking [NutchTool 
](https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/util/NutchTool.java)
 could be the class for incorporating the change, let me know your thoughts!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Job Id in Job Failure messages
> ----------------------------------
>
>                 Key: NUTCH-2923
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2923
>             Project: Nutch
>          Issue Type: Improvement
>          Components: crawldb, fetcher, generator, injector
>            Reporter: Prakhar Chaube
>            Priority: Minor
>
> In Job classes in case job doesn't succeed a failure message is initialized 
> as follows:
> _String message = "Generator job did not succeed, job status:"_
>               _+ job.getStatus().getState() + ", reason: "_
>               _+ job.getStatus().getFailureInfo();_
> However, this message doesn't contain JobId which can make it really hard to 
> reach the exact job from the logs. Adding JodId to this message will make it 
> easier to track and locate for debugging.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to