[
https://issues.apache.org/jira/browse/NUTCH-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060138#comment-18060138
]
ASF GitHub Bot commented on NUTCH-3085:
---------------------------------------
lewismc opened a new pull request, #898:
URL: https://github.com/apache/nutch/pull/898
This PR is part # 2 of NUTCH-3085 and builds on
https://github.com/apache/nutch/pull/897
**Fix JaCoCo report failure**: The jacoco-report Ant target was scanning
build/plugins/**/*.jar for class files, which inadvertently included
third-party dependency JARs (Hadoop, Tika, etc.) deployed alongside plugin
JARs. JaCoCo failed processing these. Changed to read .class files directly
from plugin build directories (build/{plugin}/classes/) instead, excluding test
classes.
**Fix SonarCloud 404 and deprecation**: Replaced the deprecated
SonarSource/sonarcloud-github-action@master with
SonarSource/sonarqube-scan-action@v5. Added PR/branch context resolution so the
scanner knows whether to perform a pull request analysis or a branch analysis
> Augment CI by adding code coverage and code quality reporting
> -------------------------------------------------------------
>
> Key: NUTCH-3085
> URL: https://issues.apache.org/jira/browse/NUTCH-3085
> Project: Nutch
> Issue Type: New Feature
> Components: ci/cd
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.23
>
>
> Back when Apache Infra operated a SonarQube service we had an Ant target
> (NUTCH-2698) which could be used to perform code quality checks. The value
> wasn't really properly realized and Infra shut down the SonarQube service so
> I removed the Ant target.
> fast forward a number of years and things have come a long way. We now use
> GitHub Actions CI and are able to [analyze the Nutch repository with a GitHub
> Action|https://docs.sonarsource.com/sonarcloud/advanced-setup/ci-based-analysis/github-actions-for-sonarcloud/].
>
> We can also add a new target to generate a code coverage report which can be
> fed into the Action to incorporate test code coverage as well.
> PR coming up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
