[
https://issues.apache.org/jira/browse/NUTCH-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060474#comment-18060474
]
ASF GitHub Bot commented on NUTCH-3085:
---------------------------------------
lewismc opened a new pull request, #901:
URL: https://github.com/apache/nutch/pull/901
* Fix JUnit report PR commenting: Add contents: read and issues: write
permissions to junit-report.yml (the action posts comments via the Issues API
and the gh api PR resolution fallback needs contents access)
* Fix plugin test double-counting: Change report glob from
./**/test/TEST-*.xml to ./*/**/test/TEST-*.xml so "JUnit Test Report Plugins"
excludes core tests
* Fix SonarCloud test report ingestion: Add a flatten step in sonarcloud.yml
to copy nested TEST-*.xml files into build/test-reports/ (SonarCloud's Surefire
sensor doesn't recurse subdirectories) and update sonar.junit.reportPaths
accordingly
* Fix sonar.java.binaries: Change from build/classes,build/plugins to
build/classes,build/*/classes to avoid scanning 456 third-party dependency JARs
deployed alongside plugin JARs
* Fix sonar.java.test.binaries: Change from build/test/classes to
build/test/classes,build/*/test to include plugin test classes
* Add sonar.java.test.libraries: Point to build/test/lib/*.jar for precise
type resolution in test code analysis
> Augment CI by adding code coverage and code quality reporting
> -------------------------------------------------------------
>
> Key: NUTCH-3085
> URL: https://issues.apache.org/jira/browse/NUTCH-3085
> Project: Nutch
> Issue Type: New Feature
> Components: ci/cd
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.23
>
>
> Back when Apache Infra operated a SonarQube service we had an Ant target
> (NUTCH-2698) which could be used to perform code quality checks. The value
> wasn't really properly realized and Infra shut down the SonarQube service so
> I removed the Ant target.
> fast forward a number of years and things have come a long way. We now use
> GitHub Actions CI and are able to [analyze the Nutch repository with a GitHub
> Action|https://docs.sonarsource.com/sonarcloud/advanced-setup/ci-based-analysis/github-actions-for-sonarcloud/].
>
> We can also add a new target to generate a code coverage report which can be
> fed into the Action to incorporate test code coverage as well.
> PR coming up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
