[jira] [Commented] (NUTCH-3173) protocol-okhttp: store OkHttp's internal URL in response metadata

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/NUTCH-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18085509#comment-18085509
 ] 

ASF GitHub Bot commented on NUTCH-3173:
---------------------------------------

sonarqubecloud[bot] commented on PR #919:
URL: https://github.com/apache/nutch/pull/919#issuecomment-4603058517

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_nutch&pullRequest=919) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_nutch&pullRequest=919&metric=new_coverage&view=list)
 (required ≥ 80%)  
     
   <!

> protocol-okhttp: store OkHttp's internal URL in response metadata
> -----------------------------------------------------------------
>
>                 Key: NUTCH-3173
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3173
>             Project: Nutch
>          Issue Type: Improvement
>          Components: plugin, protocol
>    Affects Versions: 1.23
>            Reporter: Sebastian Nagel
>            Priority: Minor
>             Fix For: 1.23
>
>
> OkHttp uses its 
> [HttpUrl|https://square.github.io/okhttp/5.x/okhttp/okhttp3/-http-url/index.html]
>  for HTTP requests. There are some differences between HttpURl and 
> java.net.URL resp. java.net.URI. And the HttpUrl.parse may parse a URL string 
> differently than Java's URL class.
> It would be good to store the stringified HttpUrl in the response metadata, 
> at least, if it differs from the original URL string. The 
> [Request|https://square.github.io/okhttp/5.x/okhttp/okhttp3/-request/index.html]
>  holds the HttpUrl object.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)