[ 
https://issues.apache.org/jira/browse/NUTCH-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18086898#comment-18086898
 ] 

Hudson commented on NUTCH-3173:
-------------------------------

SUCCESS: Integrated in Jenkins build Nutch ยป Nutch-trunk #240 (See 
[https://ci-builds.apache.org/job/Nutch/job/Nutch-trunk/240/])
NUTCH-3173 protocol-okhttp: store OkHttp's internal URL in response metadata 
(#919) (github: 
[https://github.com/apache/nutch/commit/9f78c72cb1a5b69205d33e2b29039a45b680404b])
* (edit) 
src/plugin/protocol-httpclient/src/java/org/apache/nutch/protocol/httpclient/HttpResponse.java
* (edit) 
src/plugin/protocol-okhttp/src/java/org/apache/nutch/protocol/okhttp/OkHttp.java
* (edit) src/java/org/apache/nutch/net/protocols/Response.java
* (edit) src/java/org/apache/nutch/protocol/Protocol.java
* (edit) 
src/plugin/protocol-okhttp/src/java/org/apache/nutch/protocol/okhttp/OkHttpResponse.java
* (edit) 
src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpRobotRulesParser.java


> protocol-okhttp: store OkHttp's internal URL in response metadata
> -----------------------------------------------------------------
>
>                 Key: NUTCH-3173
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3173
>             Project: Nutch
>          Issue Type: Improvement
>          Components: plugin, protocol
>    Affects Versions: 1.23
>            Reporter: Sebastian Nagel
>            Priority: Minor
>             Fix For: 1.23
>
>
> OkHttp uses its 
> [HttpUrl|https://square.github.io/okhttp/5.x/okhttp/okhttp3/-http-url/index.html]
>  for HTTP requests. There are some differences between HttpURl and 
> java.net.URL resp. java.net.URI. And the HttpUrl.parse may parse a URL string 
> differently than Java's URL class.
> It would be good to store the stringified HttpUrl in the response metadata, 
> at least, if it differs from the original URL string. The 
> [Request|https://square.github.io/okhttp/5.x/okhttp/okhttp3/-request/index.html]
>  holds the HttpUrl object.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to