lewismc commented on code in PR #958:
URL: https://github.com/apache/nutch/pull/958#discussion_r4050836912
##########
src/bin/nutch:
##########
@@ -147,17 +147,18 @@ fi
local=true
-# NUTCH_JOB
-if [ -f "${NUTCH_HOME}"/*nutch*.job ]; then
- local=false
- for f in "$NUTCH_HOME"/*nutch*.job; do
+# NUTCH_JOB
+for f in "${NUTCH_HOME}"/*nutch*.job; do
Review Comment:
I agree. More than one *nutch*.job already means a messy NUTCH_HOME. This
change only makes the glob shellcheck-safe and takes the first match. Happy to
fail closed on multiples in a follow-up if you want that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
