lewismc commented on code in PR #958:
URL: https://github.com/apache/nutch/pull/958#discussion_r4050847537
##########
src/bin/nutch:
##########
@@ -336,7 +337,7 @@ else
# check that hadoop can be found on the path
if [ $(which hadoop | wc -l ) -eq 0 ]; then
echo "Can't find Hadoop executable. Add HADOOP_COMMON_HOME/bin to the path
or run in local mode."
- exit -1;
Review Comment:
Yes this was some education for me. `1` would mean “no segment” for
bin/crawl + Generator... which is misleading/incorrect.
A missing Hadoop is now exit `127` (POSIX utility-not-found) in `bin/nutch`
and `bin/crawl`, so that path is no longer confused with an empty generate.
`ToolRunner` still mapping some exceptions to `1` is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
