On Thu, Mar 5, 2020 at 10:22 PM Gregory Nutt <spudan...@gmail.com> wrote: > > The decision to squash or not will be left to the best judgement of the > committer.
Yes, committer could give the suggestion, or even decline the PR, but it isn't good practice to directly do squash without any discussion. Even worse, committer may do some change in the squash process and then introduce the potential build break or runtime bug. Our precheck system is almost ready now: https://github.com/apache/incubator-nuttx/pull/261 https://github.com/apache/incubator-nuttx-apps/pull/113 But the precheck can just catch the error in PR. If maintainer make any change locally and commit it directly to the mainline, the whole precheck system just become another Maginot Line.
