On Thu, Mar 5, 2020 at 5:30 PM David Sidrane <david.sidr...@nscdg.com>
wrote:
> Isn't that is just more noise?
>
Noise that you can filter is less noisy.
If you do have a PR with B1 and B2 commits and generates in master:
A1 <- B1 <- B2 <- C1 <- master
you cannot filter it easily.
If you generate with branch merges:
A <------------- B <- C <- master
^- B1 <- B2 <-/
then using git log gives:
C
B
B1
B2
A
but git log --merges gives:
C
B
A
so it is way less noisy but you do not remove from the repo the subcommit
information (a.k.a. as noise by the people that don't need/care that
information)
Anyway, if the common used tool (aka Github web interface) does not provide
that option, maybe yes, it is always noise for most people. So I probably
agree with you in this case and anyway I will use whatever the community
decide to use.
> -----Original Message-----
> From: Miguel Ángel Herranz [mailto:mig...@midokura.com.INVALID]
> Sent: Thursday, March 05, 2020 8:16 AM
> To: dev@nuttx.apache.org
> Subject: Re: squashing commits or not
>
> Why not just leave all the commits and generate on master a single merge
> commit?
>
> In git CLI you can easily filter the non-merge commits using `git log
> --merges` (same sequence as squashed PR) and then inspect the involved
> commits looking at the non-master commit parent.
>
> Not sure if the problem is that Github UI is not able to filter this way.
>
> On Thu, Mar 5, 2020 at 5:00 PM Gregory Nutt <spudan...@gmail.com> wrote:
>
> > We have to trust that committers will do the best job that they can. We
> > have no control over how committers do that job. There is no mechanism
> > for such control. This is an area where there is no option but to trust
> > the judgement of the committers.
> >
> > Discussing good practice is fine, but there is no authority to control
> > the behavior of the committers. The committers are free to do as they
> > choose. The only "punishment" is peer pressure and social acceptance.
> >
> >
> >
>
> --
>
> Miguel Ángel Herranz Trillo
>
> Software developer
>
> mig...@midokura.com
>
> All rights reserved. All logos and descriptions are property of their
> respective owners
>
>
>
>
>
> LEGAL NOTICE: This mail and its attached files are confidential and are
> exclusively intended to their addresses. In case you may receive this mail
> not being its address, we beg you to let us know the error by reply and to
> proceed to delete it. The circulation by any mean of this mail could be
> penalized in accordance with the applicable legislation. The use of both
> the transmitter and the addresses with a commercial aim, or in order to be
> incorporated to automated files, is not authorized.
>
--
Miguel Ángel Herranz Trillo
Software developer
mig...@midokura.com
All rights reserved. All logos and descriptions are property of their
respective owners
LEGAL NOTICE: This mail and its attached files are confidential and are
exclusively intended to their addresses. In case you may receive this mail
not being its address, we beg you to let us know the error by reply and to
proceed to delete it. The circulation by any mean of this mail could be
penalized in accordance with the applicable legislation. The use of both
the transmitter and the addresses with a commercial aim, or in order to be
incorporated to automated files, is not authorized.
