I didn't track bugfixes when I looked through the PRs, I'll go back and look at them, should be able to do it tomorrow.
-adam On Thu, Apr 9, 2020 at 5:02 PM Abdelatif Guettouche < abdelatif.guettou...@gmail.com> wrote: > I don't know how you and Nathan proceeded, but I went through all the > PRs and kept those with significant changes. > Only the "Major Changes to Core OS" bullet has a "bugfixes" list. > The other have "significant improvements" lists, so I put everything > other than "new" or "removed" there. > > On Fri, Apr 10, 2020 at 12:33 AM Adam Feuer <a...@starcat.io> wrote: > > > > Abdelatif, > > > > Looks good to me. Thanks! > > > > Are we ready to work on summarizing the bugfixes now? > > > > -adam > > > > On Thu, Apr 9, 2020 at 4:09 PM Abdelatif Guettouche < > > abdelatif.guettou...@gmail.com> wrote: > > > > > The list of the PRs where all under "Features Added" so we lost some > > > organization in the page. I guess this is what you referred to when > > > you said that we want them in order. > > > Here how it looked before: > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=148645728 > > > > > > I tried to put everything in the right place and added other notes > > > from my range of PRs. > > > Please take a look. > > > > > > Also, I didn't want to remove the PRs number, maybe Nathan still needs > > > them. > > > > > > On Thu, Apr 9, 2020 at 10:11 PM Adam Feuer <a...@starcat.io> wrote: > > > > > > > > Ok, I categorized the features to try to add some meaning to them: > > > > > > > > https://cwiki.apache.org/confluence/display/NUTTX/NuttX+9.0 > > > > > > > > What do you think? If this is good, we can go on to listing bugs, and > > > split > > > > the PRs up... > > > > > > > > -adam > > > > > > > > On Thu, Apr 9, 2020 at 12:39 PM Adam Feuer <a...@starcat.io> wrote: > > > > > > > > > I think putting them in some kind of order is helpful, to give them > > > > > meaning... that's helpful for users. I would rather not look > through a > > > > > 20-point list to have to pick out the important things... I want > > > someone > > > > > else to do that for me, or at least try. :) > > > > > > > > > > -adam > > > > > > > > > > On Thu, Apr 9, 2020 at 12:29 PM Abdelatif Guettouche < > > > > > abdelatif.guettou...@gmail.com> wrote: > > > > > > > > > >> > It would be a GREAT help if in the future all contributors fill > out > > > the > > > > >> PR > > > > >> > description with a little bit of info. Most PRs had nothing or > very > > > > >> little, > > > > >> > which meant I was going by title or looking at code which was > hard. > > > > >> I had the exact same experience, having to go through the code to > > > > >> determine what the PR was actually about was no fun. Maybe it's > time > > > > >> to put in a PR_TEMPLATE. > > > > >> > > > > >> > Now for features, now we need to prioritize the features by > > > importance. > > > > >> Who > > > > >> > can do that? > > > > >> Why do we want to prioritize them? > > > > >> I guess we can just pick them as they arrived. > > > > >> > > > > >> > > > > >> On Thu, Apr 9, 2020 at 8:05 PM Adam Feuer <a...@starcat.io> > wrote: > > > > >> > > > > > >> > I did PRs 466-761. Lots of bugfixes, not many true added > features. I > > > > >> added > > > > >> > the feature info to the 9.0 release notes wiki page > > > > >> > <https://cwiki.apache.org/confluence/display/NUTTX/NuttX+9.0>. > > > > >> > > > > > >> > It would be a GREAT help if in the future all contributors fill > out > > > the > > > > >> PR > > > > >> > description with a little bit of info. Most PRs had nothing or > very > > > > >> little, > > > > >> > which meant I was going by title or looking at code which was > hard. > > > > >> > > > > > >> > Now for features, now we need to prioritize the features by > > > importance. > > > > >> Who > > > > >> > can do that? > > > > >> > > > > > >> > And for bug fixes... shall we take a run through the lists > again and > > > > >> pull > > > > >> > out important bug fixes? Or does anyone have another idea? > > > > >> > > > > > >> > -adam > > > > >> > > > > > >> > > > > > >> > On Tue, Apr 7, 2020 at 4:30 PM Abdelatif Guettouche < > > > > >> > abdelatif.guettou...@gmail.com> wrote: > > > > >> > > > > > >> > > I skimmed my range of PRs and created a draft PR[1] where I > > > updated > > > > >> the > > > > >> > > ReleaseNote document. I basically went through all the PRs and > > > > >> selected > > > > >> > > only those with significant changes. This is also a work in > > > > >> progress, I'll > > > > >> > > wait for Nathan to sort his notes in the wiki before I move > mine > > > > >> there. > > > > >> > > > > > > >> > > To go back to the release notes discussion and where they > should > > > be, > > > > >> if we > > > > >> > > keep only the latest release notes in the top level > ReleaseNote > > > file > > > > >> they > > > > >> > > will never be decoupled from the release. Brennan's script can > > > also be > > > > >> > > updated to fetch them out. > > > > >> > > The current ReleaseNote file has 26620 lines, it's hard to > focus > > > > >> there. > > > > >> > > > > > > >> > > On Fri, Apr 3, 2020 at 9:20 PM Nathan Hartman < > > > > >> hartman.nat...@gmail.com> > > > > >> > > wrote: > > > > >> > > > > > > >> > > > On Thu, Apr 2, 2020 at 8:11 PM Adam Feuer <a...@starcat.io> > > > wrote: > > > > >> > > > > Ok, so let's split up the PRs with the three people we > have > > > now, > > > > >> > > > Abdelatif, > > > > >> > > > > Nathan, and me. As new people join, we can give them > ranges to > > > > >> look at. > > > > >> > > > > > > > > >> > > > > Let's do features first: > > > > >> > > > > > > > > >> > > > > - Abdelatif: PRs: 1-232 > > > > >> > > > > - Nathan: PRs: 233-465 > > > > >> > > > > - Adam: PRs: 466-697 > > > > >> > > > > > > > > >> > > > > Read the PRs, take notes as a bulleted list, and add to > the > > > wiki > > > > >> here > > > > >> > > > under > > > > >> > > > > 2b Features: > > > > >> > > > > > > > > >> > > > > > https://cwiki.apache.org/confluence/display/NUTTX/NuttX+9.0 > > > > >> > > > > > > > >> > > > I added a very INITIAL list of PRs from 233 to 465 that I > think > > > are > > > > >> > > > new features. This is a WORK IN PROGRESS! It's by no means > > > finished > > > > >> > > > text and will obviouslyneed a lot of refinement. At this > point, > > > I'll > > > > >> > > > need to study each of those PRs in more detail to decide > how the > > > > >> > > > description should be worded and whether they should be > moved to > > > > >> other > > > > >> > > > sections. But for now, my work-in-progress is there... > > > > >> > > > > > > > >> > > > Cheers, > > > > >> > > > Nathan > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > -- > > > > >> > Adam Feuer <a...@starcat.io> > > > > >> > > > > > > > > > > > > > > > -- > > > > > Adam Feuer <a...@starcat.io> > > > > > > > > > > > > > > > > > -- > > > > Adam Feuer <a...@starcat.io> > > > > > > > > > -- > > Adam Feuer <a...@starcat.io> > -- Adam Feuer <a...@starcat.io>
