> - It would be nice to see more than " * Releases may have incomplete > licensing conditions.” in the WIP disclaimer > - In NOTICE I’d move "This product includes software developed at” to the top
I created a PR to address the NOTICE file. For the DISCLAIMER, does anyone have any ideas what should be included? Justin suggested the same thing the first time we created the file, I went through I guess all podlings with WIP disclaimer for some inspiration but didn't find any. > In this case, the uImage binary was in a PR and got merged directly into > the repository. Since it is a binary file, it slipped throught he PR > review. I don't think PR842 would have caught it in that case, would it? I guess with PR842 and 841 the checks would clean any ignored file that's somehow present in the repo. On Fri, Apr 24, 2020 at 5:14 PM Gregory Nutt <spudan...@gmail.com> wrote: > > > >> We can still exclude it from the tarballs with ./tools/zipme.sh -e "uImage" > > Once we finish this PR: > > https://github.com/apache/incubator-nuttx/pull/842 > > This type of error will be caught by our build system automatically. > In this case, the uImage binary was in a PR and got merged directly into > the repository. Since it is a binary file, it slipped throught he PR > review. I don't think PR842 would have caught it in that case, would it?
