Yes, I remove #if/#endif intentionally because it doesn't make sense that user disable all three method which provide the critical memory info to OS.
-----Original Message----- From: Abdelatif Guettouche <abdelatif.guettou...@gmail.com> Sent: Thursday, May 7, 2020 1:18 PM To: dev@nuttx.apache.org Subject: Re: New unused variables warning in nx_start() Removing this [1] ifdefs introduced the warning in a flat build. 1. https://github.com/apache/incubator-nuttx/commit/eca70597858bc619d3114901d16e4a30f1ebffbe#diff-e36621b38d26a5eeb9f0c9c779931e7bL548 On Wed, May 6, 2020 at 7:11 PM Nathan Hartman <hartman.nat...@gmail.com> wrote: > > On Wed, May 6, 2020 at 12:25 PM Xiang Xiao <xiaoxiang781...@gmail.com> wrote: > > Should you at least use one method to give OS the basic heap? Can you boot > > nuttx into nsh with the current configuration? > > I don't know yet, because I cannot load and run it right now. > > I have a feeling that something has changed in the implementation > recently, or configuration options have changed and I need to 'make > oldconfig' or examine what is happening in my configuration. > > If it is required to have at least one of these three options, then > perhaps compile-time logic should check if no heap will be available > and output a warning? > > Nathan
