On Thu, May 7, 2020 at 1:30 PM Gregory Nutt <spudan...@gmail.com> wrote: > > On 5/7/2020 11:29 AM, Nathan Hartman wrote: > > On Thu, May 7, 2020 at 12:49 PM Gregory Nutt <spudan...@gmail.com> wrote: > >> No.. this code was broken with with commit > >> eca70597858bc619d3114901d16e4a30f1ebffbe . There is no point trying to > >> make sense out of this. It is just broken and needs to be fixed. > > (snip) > > > >> So there is not a lot of sense in us discussing the meaning of broken > >> code. It has not meaning. It is just wrong and needs to be fixed. > >> Please submit a PR. I think you just need to back out that portion of > >> commit eca70597858bc619d3114901d16e4a30f1ebffbe > > In other words, I should wrap this block in: > > > > #if defined(MM_KERNEL_USRHEAP_INIT) || > > defined(CONFIG_MM_KERNEL_HEAP) || \ > > defined(CONFIG_MM_PGALLOC) > > . > > . > > . > > #endif > yes, or whatever all of the dependencies are in the compound statement. > > Or is anything more needed? > No >
Okay thanks. PR coming shortly... Cheers, Nathan
