That looks good. Just one small thing: Is your board in-tree with other STM32s? I'm asking because the referenced commit didn't make the change to the build system, it re-organized the STM32 boards. The "real" change to the build system was made in a previous release (8.2?) when Alin and Greg re-organized the boards directory. So for people using out-of-tree boards, they should not see any issue, in-tree boards will need to do the changes as mentioned in the link.
On Fri, May 15, 2020 at 3:23 AM Nathan Hartman <hartman.nat...@gmail.com> wrote: > > On Thu, May 14, 2020 at 6:40 PM Abdelatif Guettouche > <abdelatif.guettou...@gmail.com> wrote: > > I noted one thing: > > "Rename src/Makefile to src/Make.defs" > > I'm not sure about this one, this applies only if the board family > > uses a common directory (like CXD56 does and recently STM32). > > The "Makefile" way still works and is still in use in the boards > > directory (and I use it with a custom board). > > Good catch! I didn't know that. It definitely did break my custom > board builds with a 'make: no rule to make...' error, but sure enough > I'm in directories that have a common directory. > > I think the text should be updated to clarify that. I'll update it > now... please take a look when you get a chance and let me know it's > accurate. > > Thanks, > Nathan
