On Tue, May 19, 2020 at 4:27 PM Gregory Nutt <spudan...@gmail.com> wrote: > > It does print "error" for some and "warnings" for others. So I thought > > there was a difference. >> > Yes, that was added. But I don't know what it means. I guess that some > stylistic violations are not as bad as others? None are tolerated, at > least not without some extenuating circumstance.
What to do about lines of code like this: [[[ # define GPIO_CNF_ANALOGIN (0 << GPIO_CNF_SHIFT) /* Analog input */ # define GPIO_CNF_INFLOAT (1 << GPIO_CNF_SHIFT) /* Input floating */ # define GPIO_CNF_INPULLUD (2 << GPIO_CNF_SHIFT) /* Input pull-up/down general bit, since up is composed of two parts */ # define GPIO_CNF_INPULLDWN (2 << GPIO_CNF_SHIFT) /* Input pull-down */ # define GPIO_CNF_INPULLUP ((2 << GPIO_CNF_SHIFT) | GPIO_OUTPUT_SET) /* Input pull-up */ # define GPIO_CNF_OUTPP (0 << GPIO_CNF_SHIFT) /* Output push-pull */ # define GPIO_CNF_OUTOD (1 << GPIO_CNF_SHIFT) /* Output open-drain */ # define GPIO_CNF_AFPP (2 << GPIO_CNF_SHIFT) /* Alternate function push-pull */ # define GPIO_CNF_AFOD (3 << GPIO_CNF_SHIFT) /* Alternate function open-drain */ ]]] Here, the complaint is: arch/arm/src/stm32/stm32_gpio.h:131:79: warning: Wrong column position of comment right of code The offending line is GPIO_CNF_INPULLUP, which has more code than the other lines. Push them all? Make the define multi-line? There are many of these so I'd like to know what is the preferred fix before I begin... Thanks, Nathan
