The rule use to be: long lines were ok in arch header files. When I made nxstyle output error parsable output, that was a warning not an error.
Then we got to make it fit below the ruler. Then we got to it better conform. So now I guess they are all errors. David -----Original Message----- From: Nathan Hartman [mailto:hartman.nat...@gmail.com] Sent: Tuesday, May 19, 2020 1:18 PM To: dev@nuttx.apache.org Subject: Re: nxstyle warnings: Fail precheck? On Tue, May 19, 2020 at 4:01 PM Gregory Nutt <spudan...@gmail.com> wrote: > > Are nxstyle warnings supposed to make precheck fail at GitHub PR? I > > thought only errors constitute fails. > > In the build checks C warnings are also converted to warnings via > -Werror and any warnings in the builds will fail the check. > > Don't know about nxstyle, but there really is no such thing as a warning > in nxstyle: It either conforms to the coding style or it does not. > DavidS added those warning, but the never made sense to me. There are > no warnings, only failures to conform to the standard. Ok. It does print "error" for some and "warnings" for others. So I thought there was a difference. Nathan
