On Fri, Feb 18, 2022 at 5:27 AM Xiang Xiao <xiaoxiang781...@gmail.com> wrote: > > On Fri, Feb 18, 2022 at 3:52 PM Petro Karashchenko < > petro.karashche...@gmail.com> wrote: > > > Hi, > > > > I agree that auto-merge should not be used. > > > > But I disagree that "as it is now since almost all patches follow the > > rule and seldom someone self-merges a patch". Here is a list of > > patches that were self merged last 12 days: > > https://github.com/apache/incubator-nuttx/pull/5474 > > https://github.com/apache/incubator-nuttx/pull/5445 > > https://github.com/apache/incubator-nuttx/pull/5444 > > https://github.com/apache/incubator-nuttx/pull/5428 > > https://github.com/apache/incubator-nuttx/pull/5425 > > https://github.com/apache/incubator-nuttx/pull/5508 > > > > All of the PRs have relatively low complexity and do not touch the > > core functionality so I'm ok with self-merging in such cases. > > > > > All come from me, I think:(. All these patch meet the following criteria: > > 1. Approved by some people > 2. Either the change is very minor > 3. Or the PR was sent a few days ago.
I think that part of the pressure to merge PRs quickly might be related to old open PRs that are lingering in the list. We have about 25 open PRs that have not been updated in 6 months or more (almost 50% of open PRs). Perhaps it would be helpful if there was some PR cleanup to remove old PRs that meet some criteria such as: 1. Not updated for 6 months or more. 2. Obsolete, incorrect, or unmergeable. 3. Not important work that should be preserved/revived. I suggest that authors of old PRs please look through your PRs and see if you want to revive them or if it's better to close them. Cheers, Nathan
