Hello,
new version of the patch series is posted in the git repository, the
branch is named avrdx_rfc2 and starts at avr_fixes_rfc2 (everything up
to and including avr_fixes_rfc2 is already merged.)
Here are the changes from previous version:
1. some formatting and typo fixes in various documents
2. as discussed above, some mixed-case constants were preserved (_bm and
_bp suffix) and some removed. Patch for the nxstyle tool that
facilitates this exception is added to the series. Non-permitted
constants with mixed-case letters are no longer used in their form from
library io.h file, instead there are new files within NuttX source tree
that provide all-uppercase constant names.
3. nxstyle cannot deal with the exceptions properly and come constants
with _bm suffix in their name were still flagged as incorrect. That is
worked around by various code shuffling, assigning into temporary
variables etc. Most places where this was needed to be done are marked
with comment along the lines of "this will make nxstyle happpy." The
code seems less readable this way but after trying to make heads or
tails of the nxstyle source code, this is the only solution I can
provide on my own.
4. after dealing with this, I found that there were some mixed-case
warnings still left - I missed them because of the quantity of others.
Specifically, it was the type USART_t, a data type which facilitates
access to a peripheral I/O registers for USART. (Other peripherals have
their types named in the same way.) I changed this one into
avrdx_usart_t and redefined it in the NuttX source as well.
There should be no checkpatch errors left.
From what I tested, the code compiles to a binary identical to previous
version of the patch series.
Any comments and reviews are appreciated.
