On Wed, Nov 12, 2025 at 12:15 AM Alan C. Assis <[email protected]> wrote: > I think it is always better to just add a comment instead of a Change > Request, but sometimes I put the a comment asking the change, but then two > people approve the PR, in this case I have no other option than add a > Change Request. > > I think this proposal is good to avoid ignoring the CR. Currently to merge > a PR all comments need to be resolved. But just like Change Request anyone > with write access can mark comments as Resolved. So Change Request is the > last barrier.
Yes, some changes may be even harmful, CR in that case blocks them, this is good behavior, and if the CR comes from a "binding" PMC member with a detailed explanation then it must not be canceled even after 72h period because this will result in vote that will be blocked by the "binding" vote anyway. I guess this discussion is about what to do with people who break CG rules right? I tired to implement github rules that would block merging with unresolved discussions, but when someone pushes an update the discussion is auto-dismissed, maybe there is a way to improve / fix this? -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
