I ran builds over all of arm with increased warnings (-Wall -Wextra
-Wsystem-headers -Wformat
-Wno-unused-parameter -Wno-missing-field-initializers
-Wno-implicit-fallthrough) to see what warnings have been hidden turns
up redefinition warnings, one of which for all builds of giant-board,
jupiter-nano and sama5d2-xult boards:
include/arch/sama5/chip.h:106: warning: "SAM_ISRAM0_SIZE" redefined
Looking at include/arch/sama5/chip.h:
# define SAM_ISRAM0_SIZE (128*1024) /* SRAM0: 128KB */
#ifdef CONFIG_ARMV7A_L2CC_PL310
# define SAM_ISRAM1_SIZE (0) /* (SRAM1 used for L2 cache )*/
#else
# define SAM_ISRAM0_SIZE (64*1024) /* SRAM1: 128KB */
#endif
I think Greg[*] meant to at line 106 to define SAM_ISRAM1_SIZE instead
of SAM_ISRAM0_SIZE. Does this make sense? I don't have any of the
mentioned boards to test with, but can create a PR.
[*]
https://github.com/apache/nuttx/commit/831272cd35692cf3bec8a1bfd4f8fc3cc8f80dbb
--
Peter Barada
[email protected]
