raiden00pl commented on code in PR #10:
URL: https://github.com/apache/nuttx-ntfc/pull/10#discussion_r3654740870
##########
src/ntfc/device/sim.py:
##########
@@ -49,7 +49,9 @@ def _start_impl(self) -> None:
uptime = self._conf.uptime
# open host-based emulation
- self.host_open(cmd, uptime)
+ child = self.host_open(cmd, uptime)
Review Comment:
what about qemu ? can we do the same for qemu?
##########
src/ntfc/device/sim.py:
##########
@@ -49,7 +49,9 @@ def _start_impl(self) -> None:
uptime = self._conf.uptime
# open host-based emulation
- self.host_open(cmd, uptime)
+ child = self.host_open(cmd, uptime)
+ if self._conf.line_buffered:
+ child.delaybeforesend = 0
Review Comment:
this setting won't survive device reopening when device crashed
(`_dev_reopen()`). It's better to move this to `host_open()`. This way we can
handle both sim and qemu at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
