casaroli commented on code in PR #10:
URL: https://github.com/apache/nuttx-ntfc/pull/10#discussion_r3657628575
##########
src/ntfc/device/sim.py:
##########
@@ -49,7 +49,9 @@ def _start_impl(self) -> None:
uptime = self._conf.uptime
# open host-based emulation
- self.host_open(cmd, uptime)
+ child = self.host_open(cmd, uptime)
Review Comment:
Depends on the target. I could use this in an521 but not on an500.
I need to test more but i am focused on some other stuff right now.
I'd just keep it for sim for now since it is very reliable and gives the
most benefit (reduces ci time considerably)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
