[ 
https://issues.apache.org/jira/browse/ODE-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806162#action_12806162
 ] 

David Carver commented on ODE-751:
----------------------------------

in org.apache.ode.bpel.compiler.bom.* there are several places with the compile 
methods like the following:


    public void compile(OActivity dest, Activity source) {
        OAssign oassign = (OAssign) dest;
        AssignActivity ad = (AssignActivity) source;
        
FindBugs is reporting that this could cause possible ClassCastExceptions 
because an Class implementing the Activity and Oactivity interfaces may not 
necessarily be able to be cast to the corresponding classes.    This is fairly 
simple to fix, but the question I have is what Exception should be tossed.   We 
don't want to toss a ClassCastException but I would suspect some sort of 
compilation exception should be thrown. 

There are about 31 bugs like this being reported in this particular package.


> FindBugs Patches for ODE Runtime
> --------------------------------
>
>                 Key: ODE-751
>                 URL: https://issues.apache.org/jira/browse/ODE-751
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>         Environment: linux
>            Reporter: David Carver
>         Attachments: odebpelapipatchv2.txt, odebpeldapatchv1.txt, 
> odebpelpatch.txt, odeutilspatchv1.txt, schedule-simple-patchv1.txt
>
>
> Running FindBugs (http://findbugs.sourceforge.net/) against the bpel-api 
> project, the following error:
> Equals method for org.apache.ode.bpel.iapi.Endpoint assumes the argument is 
> of type Endpoint
> Will attach a patch to correct these issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to